Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CostWrapper could/should be a function, not a class #10

Open
ilectra opened this issue Jul 1, 2019 · 2 comments
Open

CostWrapper could/should be a function, not a class #10

ilectra opened this issue Jul 1, 2019 · 2 comments

Comments

@ilectra
Copy link
Contributor

ilectra commented Jul 1, 2019

No data in it is used/called on its own, it's only used to calculate the cost once.
@jgomezdans
Copy link
Collaborator

In a way. However if using trust-krylov function minimiser in scipy, the idea of CostWrappre is to cache common calculations for the cost function, its Jacobian and the hessianp (hessian times product). Check pr1

@jgomezdans
Copy link
Collaborator

See also #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgomezdans @ilectra