fix: add appendCard() event for plugin support

Author: feildmaster

changelog.md

@@ -1,5 +1,8 @@
 # UnderScript Changelog
 
+## Version 0.51.1 (2022-10-30)
+1. Fix issue where PrettyCards would break descriptions
+
 ## Version 0.51.0 (2022-10-29)
 ### New Features
 1. Added events for ALL `appendCard` functions

src/base/vanilla/card.append.js

@@ -1,24 +1,34 @@
+import getExtras from '../../utils/appendCardExtras';
 import each from '../../utils/each';
 import eventEmitter from '../../utils/eventEmitter';
 import eventManager from '../../utils/eventManager';
 import { globalSet } from '../../utils/global';
+import VarStore from '../../utils/VarStore';
 
 const PREFIX = 'appendCard';
 const internal = eventEmitter();
 let event = PREFIX;
 let data;
+const extras = VarStore();
 
 internal.on('set', (e = PREFIX) => {
   event = e;
 }).on('pre', (...args) => {
   eventManager.emit(`pre:func:${event}`, ...args);
 }).on('post', (...args) => {
-  if (event === PREFIX || data && !args.length) {
-    eventManager.emit(`func:${event}`, ...(data || args));
+  if (event === PREFIX || !args.length) {
+    const eventData = data || args;
+    if (eventData.length) eventManager.emit(`func:${event}`, ...eventData);
     data = null;
     event = PREFIX; // Reset
   } else {
     data = args;
+    if (extras.isSet()) data.push(...extras.value);
+    eventManager.emit(`${PREFIX}()`, { // Support old events
+      card: args[0],
+      element: args[1],
+    });
+    eventManager.emit(`func:${PREFIX}`, ...data); // Should always call `appendCard`?
   }
 });
 
@@ -35,15 +45,18 @@ eventManager.on(':loaded', () => {
 
   function override(key) {
     globalSet(key, function func(...args) {
+      extras.value = getExtras(key, args);
       internal.emit('set', key);
       const ret = this.super(...args);
       internal.emit('post');
       return ret;
     });
   }
 
+  const otherKeys = ['showCardHover'];
   each(window, (_, key = '') => {
-    if (key !== PREFIX && key.startsWith(PREFIX) ||
-        key === 'showCardHover') override(key);
+    if (key !== PREFIX && key.startsWith(PREFIX) || otherKeys.includes(key)) {
+      override(key);
+    }
   });
 });

src/utils/VarStore.js

@@ -28,5 +28,5 @@ export default function VarStore(def) {
     set,
   });
 
-  return ret;
+  return Object.freeze(ret);
 }

src/utils/appendCardExtras.js

@@ -0,0 +1,11 @@
+const argExtractor = {
+  appendCardCardSkinShop: (...args) => args,
+  appendCardFriendship: (_, ...args) => args,
+  showCardHover: (...args) => args,
+};
+
+export default function getExtras(key, args = []) {
+  const extractor = argExtractor[key];
+  if (!extractor) return null;
+  return extractor(...args);
+}