Skip to content

Commit 4e9cdc6

Browse files
committed
feat(settings): expose name on setting creation
1 parent 77827b2 commit 4e9cdc6

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

changelog.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# UnderScript Changelog
22

3-
## Version 0.60.0 (2025-03-15)
3+
## Version 0.60.1 (2025-03-15)
44
The great plugin (& bug fix) update
55
### Fixes
66
1. Deck Storage now translates card names
@@ -14,6 +14,10 @@ The great plugin (& bug fix) update
1414
1. Added `map` setting type
1515
1. Allow event listeners to be turned off
1616
1. Renamed event `:loaded` to `:preload`
17+
1. Added `name` to setting creation
18+
19+
## Version 0.60.0 (2025-03-15)
20+
- See v0.60.1
1721

1822
## Version 0.59.0 (2025-01-31)
1923
New release for a new year. Enjoy~

src/utils/settings/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ function createSetting(setting = defaultSetting) {
8989
events.emit(`create:${key}`);
9090
ret.addClass(getCSSName(type.name));
9191
const container = $(`<div>`).addClass('flex-stretch');
92+
const name = translateText(setting.name);
9293
const el = $(type.element(setting.value, (...args) => {
9394
if (!updateLock) updateLock = setting;
9495
setting.update(...args);
@@ -97,6 +98,7 @@ function createSetting(setting = defaultSetting) {
9798
data: setting.data,
9899
remove: setting.remove,
99100
container,
101+
name,
100102
key,
101103
removeSetting() {
102104
removeSetting(setting, el);
@@ -106,7 +108,7 @@ function createSetting(setting = defaultSetting) {
106108
id: key,
107109
});
108110

109-
const label = $(`<label for="${key}">`).html(translateText(setting.name));
111+
const label = $(`<label for="${key}">`).html(name);
110112
const labelPlacement = type.labelFirst();
111113
if (labelPlacement) {
112114
ret.append(label, ' ', el);
@@ -140,6 +142,7 @@ function createSetting(setting = defaultSetting) {
140142
// TODO: reset is technically dynamic
141143
el.prop('disabled', setting.disabled);
142144
label.toggleClass('disabled', setting.disabled);
145+
label.html(translateText(setting.name)); // Name is dynamic...
143146
}
144147
refresh();
145148
untilClose(`refresh:${key}`, refresh, `create:${key}`);

0 commit comments

Comments
 (0)