Skip to content

Commit 065bd52

Browse files
committed
remove some additional lint
1 parent 5e36629 commit 065bd52

File tree

4 files changed

+10
-13
lines changed

4 files changed

+10
-13
lines changed

tests/test_params.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
def test_parameters_to_expected(datadir):
1212
with as_cwd(datadir):
1313
mod = importlib.import_module("barrier3d-parameters-expected")
14-
expected = {
15-
k: v for k, v in mod.__dict__.items() if not k.startswith("_")
16-
}
14+
expected = {k: v for k, v in mod.__dict__.items() if not k.startswith("_")}
1715
actual = load_inputs(datadir, prefix="barrier3d-default", fmt="yaml")
1816

1917
for key in actual:
@@ -45,7 +43,7 @@ def test_barrier3d_configuration(datadir):
4543
actual.pop("RNG")
4644
expected.pop("RNG")
4745

48-
for key, value in expected.items():
46+
for key in expected:
4947
assert actual[key] == expected[key], f"mismatch in values for {key}"
5048

5149

tests/test_params/barrier3d-default-parameters.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,11 @@
113113
# For lognormal probability distribution of seed dispersal distance
114114
disp_sigma = 1.5
115115
# File that contains initial dune height values [m]
116-
dune_file = PosixPath('barrier3d-default-dunes.npy')
116+
dune_file = PosixPath("barrier3d-default-dunes.npy")
117117
# File that contains initial elevations in [m MHH]
118-
elevation_file = PosixPath('barrier3d-default-elevations.npy')
118+
elevation_file = PosixPath("barrier3d-default-elevations.npy")
119119
# File that contains initial growth parameters
120-
growth_param_file = PosixPath('barrier3d-default-growthparam.npy')
120+
growth_param_file = PosixPath("barrier3d-default-growthparam.npy")
121121
# Shoreface flux rate constant
122122
k_sf = 5000.0 # [m^3 / m / y]
123123
# Exponent constant for sediment transport
@@ -131,6 +131,6 @@
131131
# Equilibrium shoreface slope
132132
s_sf_eq = 0.02
133133
# File that contains storm data
134-
storm_file = PosixPath('barrier3d-default-storms.npy')
134+
storm_file = PosixPath("barrier3d-default-storms.npy")
135135
# Threshold to determine if in inundation regime
136136
threshold_in = 0.25 # [m^3 / hr]

tests/test_versions.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
1-
import os
21
import pathlib
32

43
import numpy as np
54
import pytest
6-
from numpy.testing import assert_array_almost_equal
75
from packaging.version import Version
86

97
from barrier3d import Barrier3dBmi
@@ -39,7 +37,7 @@ def test_BMI_against_V1(tmpdir, datadir):
3937
barrier3d.initialize(datadir / "barrier3d-default-parameters.yaml")
4038

4139
# increase time step
42-
for time_step in range(1, barrier3d._model._TMAX):
40+
for _ in range(1, barrier3d._model._TMAX):
4341
barrier3d.update()
4442

4543
# dune height over time

version1_local_copy/Barrier3D_Parameters.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@
1212
# Version Number: 4
1313
# Updated: 30 April 2021
1414

15-
16-
import math
1715
# Script sets up all input parameters
1816
# Converts from meters to decameters for simulation
17+
18+
19+
import math
1920
import pathlib
2021

2122
import numpy as np

0 commit comments

Comments
 (0)