Query /locations with No Parameters Fails

[krowvin]

Issue

If you query the /locations endpoint (GET) with no parameters the request fails with a 500.

Reproduce

curl -X 'GET' \
  'https://cwms-data.usace.army.mil/cwms-data/locations' \
  -H 'accept: application/json;version=2'

Error:

You get a 500 on the client/api response.

The logs for tomcat show:

cwms.cda.api.LocationController.getAll -1177377251864346337: failed to process request java.time.DateTimeException: Invalid ID for region-based ZoneId, invalid format: Unknown or Not Applicable

Details / Assumptions

The Location endpoint suggests in the swagger page that it is valid to query without a office or any location.

Under office you see:

If this field is not specified, matching location level information from all offices shall be returned.

Solutions

While the /catalog endpoint might be better (add a reference to catalog from locations endpoint?), the locations endpoint still suggests it is useable for querying multiple locations.

In another issue a user also wants to query all locations through the /locations

• Ability to retrieve all location data in CDA #1189

Reported in [07/14/2025] CDA BiWeekly

[rma-rripken]

I haven't tried to reproduce this but I'd bet that there are Locations in the db with timezoneNames that don't parse by ZoneId. Might there be a Location in your db where the timezoneName is the literal string "Unknown or Not Applicable"? Looking at LocationDaoImpl it looks to me like it parses the name into the matching ZoneId and then does a toString on the zoneId. How are Locations like that being built? If bogus timezoneNames are valid and the field is truly free-form then we should change the LocationDaoImpl to not even parse it.

We've hit this in another issue. I feel like the suggestion in the other issue is that there are only a limited number of non-standard timezoneNames that we want to support and that we can add those to ZoneId.

We certainly could handle the parsing failure better.

[rma-rripken]

Related: #987

[rma-rripken]

Also related #957

[rma-rripken]

This line

cwms-data-api/cwms-data-api/src/main/java/cwms/cda/data/dao/LocationsDaoImpl.java

Line 151 in aa1dc02

zone = ZoneId.of(timeZoneName);

needs to use: this method instead: https://docs.oracle.com/javase/8/docs/api/java/time/ZoneId.html#of-java.lang.String-java.util.Map-

And we need to tell it the timezone aliases to use. Can start with a hard-coded list.
Its like 10 lines of code.

[rma-rripken]

Slightly more involved. #1200

[MikeNeilson]

I agree with at least starting with a hard coded list, it's not like there's a massive amount of aliases.

[rma-rripken]

@krowvin please test again on dev. Merged PR may have fixed

[krowvin]

Confirmed this is resolved in dev version 2025.09.23-develop, will be resolved when 09.23.2025+ is merged to PROD