Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert more waves data to CF and harvest in portal? #279

Open
emontgomery-usgs opened this issue Mar 26, 2018 · 15 comments
Open

Convert more waves data to CF and harvest in portal? #279

emontgomery-usgs opened this issue Mar 26, 2018 · 15 comments
Assignees

Comments

@emontgomery-usgs
Copy link
Contributor

@rsignell-usgs , @kwilcox
We intentionally exclude some files that include wave height and period because other variables in the files are dimensioned oddly (by time and frequency). Is it time to revisit this?

In this example https://stellwagen.er.usgs.gov/thredds/dodsC/TSdata/MVCO_15/10571whVp-cal.nc.html, variables named *spec have dimensions that don't fit any CF models (as far as I know), but wh_4061 and wp_4060 are just dimensioned by (time, lat and lon), so should go to CF fine. Can the other variables be passed as-is to a CF version of the file?

If we want to try this, adding "p-cal", and "Wvs-cal" to the already complicated regex should pull in more wave data.

@emontgomery-usgs
Copy link
Contributor Author

emontgomery-usgs commented May 16, 2018

@kwilcox , any chance of implementing this soonish?
@rsignell-usgs, please check to see if you agree with the mappings I've picked for our variable names found in waves files.

our name CF name
wh_4061 sea_surface_wave_significant_height
wp_4060 sea_surface_wave_mean_period
mwh_4064 sea_surface_wave_maximum_height
wp_peak sea_surface_wave_significant_period
wvdir sea_surface_wave_from_direction

New filenames that would need to be included in the regex:
wvs_ (NOT wvsb-cal), p-cal

Thanks!

@rsignell-usgs
Copy link
Member

@dnowacki-usgs can you review this please?

@dnowacki-usgs
Copy link
Member

I suggest the following changes:

wp_4060: At least in EPR and GrandBay, we have been computing wp_4060 as sqrt(m0/m2) which would correspond to sea_surface_wave_mean_period_from_variance_spectral_density_second_frequency_moment and not sea_surface_wave_mean_period.

wp_peak: Peak period as we define it is the period associated with the greatest energy in the spectra. So it should be sea_surface_wave_period_at_variance_spectral_density_maximum and not sea_surface_wave_significant_period.

In reading the CF standard names I'm honestly not sure which of sea_surface_wave_from_direction_at_variance_spectral_density_maximum and sea_surface_wave_from_direction should correspond to wvdir and dwvdir.

@rsignell-usgs
Copy link
Member

For wvdir and dwvdir you not sure of what we have or not sure of what CF specifies?

@dnowacki-usgs
Copy link
Member

dnowacki-usgs commented May 18, 2018

I find the CF standard names somewhat imprecise.

First, sea_surface_wave_from_direction doesn't specify how the wave direction is derived; the definition text deals only with semantics of how direction is defined (from, clockwise from due north).

The definition sea_surface_wave_from_direction_at_variance_spectral_density_maximum is:

The quantity with standard name sea_surface_wave_from_direction_at_variance_spectral_density_maximum is the direction from which the most energetic waves are coming. The spectral peak is the most energetic wave in the total wave spectrum.

We define dwvdir as "the compass direction from which waves are propagating as defined by the direction band with greatest total energy summed over all frequencies"

We define wvdir as "the compass direction from which waves are propagating as defined by the direction with the greatest energy at the peak period"

I guess sea_surface_wave_from_direction_at_variance_spectral_density_maximum is closer to dwvdir than wvdir but I'm not 100%.

@emontgomery-usgs
Copy link
Contributor Author

@rsignell-usgs - can we go with Dan's suggestions and move forward with this?

@emontgomery-usgs
Copy link
Contributor Author

@kwilcox , @rsignell-usgs
please:

  1. modify the file regex to allow files with wvs_ and p-cal
  2. modify the following mappings in https://github.com/axiom-data-science/epic2cf/blob/master/epic2cf/data.py#L747-L750. THese EPIC codes should be
    4060 -> sea_surface_wave_mean_period_from_variance_spectral_density_second_frequency_moment
    4061 -> sea_surface_wave_significant_height
    4064 -> sea_surface_wave_maximum_height
  3. find a way to map these with no EPIC code
    wp_peak -> sea_surface_wave_period_at_variance_spectral_density_maximum
    wvdir -> sea_surface_wave_from_direction
    dwvdir -> sea_surface_wave_from_direction_at_variance_spectral_density_maximum

Thanks!

@kwilcox kwilcox assigned kwilcox and rsignell-usgs and unassigned kwilcox Jul 6, 2018
@emontgomery-usgs
Copy link
Contributor Author

@rsignell-usgs, why did you unassign kyle on this ticket? I think we are ready to go on this.

@rsignell-usgs
Copy link
Member

Looks like @kwilcox unassigned himself and assigned me.

@kwilcox
Copy link
Contributor

kwilcox commented Jul 30, 2018

Just want to confirm that all existing wave data in the portal should be transitioned from sea_surface_wave_mean_period to sea_surface_wave_mean_period_from_variance_spectral_density_second_frequency_moment

@emontgomery-usgs
Copy link
Contributor Author

emontgomery-usgs commented Jul 30, 2018 via email

@emontgomery-usgs
Copy link
Contributor Author

emontgomery-usgs commented Aug 3, 2018

@emontgomery-usgs
Copy link
Contributor Author

Here's another new standard_name we should probably assign: sea_surface_wave_variance_spectral_density.

Should it be applied to pspec, vspec, sspec or all?

@dnowacki-usgs
Copy link
Member

dnowacki-usgs commented Apr 2, 2019

I think it could be applied to all, as they are just different ways at getting at the same quantity, via pressure fluctuations, surface detection fluctuations, and velocity fluctuations. Note that the units of pspec, vspec, sspec from an RDI are the square-root of the units specified by the standard name table. The RDI values on stellwagen are not really a variance but more a standard deviation, with units m/sqrt(Hz) = m sqrt(s). This might be allowable, based on my reading of the FAQ, as they are convertible (by squaring) to the canonical units, but we might want to present them in the form specified by the table, i.e. as m2 s.

@kwilcox
Copy link
Contributor

kwilcox commented Apr 9, 2019

@emontgomery-usgs I've got everything hooked up to process waves files, just tested with http://geoport.whoi.edu/thredds/dodsC/silt/usgs/Projects/stellwagen/Data/CHINCOTEAGUE/10191Aaqdwvs_diwasp-cal.nc.html and it was converted now. Is there anything you want to do with the variables based on frequency before I push these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants