Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area-weighting inconsistent between grid area and outlet upstream area #93

Closed
lizaclark opened this issue Mar 30, 2016 · 1 comment
Closed

Comments

@lizaclark
Copy link
Contributor

Following on issue #92 The area-weighting uses grid_area as a multiplier then divides by self._outlet_upstream_area; however, self._outlet_upstream_area is the multiple of the grid cell area and the grid cell fraction link. grid_area appears to just be the grid cell area link, not the grid cell area within the basin. grid_area should probably be grid_area * dom_data[dom_frac][outlet.y_source, outlet.x_source]

@lizaclark
Copy link
Contributor Author

The grid_area is multiplied by kg m-2 s-1 to convert to kg s-1 mass flux. It is not an area-weighting as I originally thought, so this issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant