Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using Find all references in Deltarune (LTS 2022.0) #1984

Closed
ners-xd opened this issue Nov 28, 2024 · 6 comments
Closed

Error when using Find all references in Deltarune (LTS 2022.0) #1984

ners-xd opened this issue Nov 28, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@ners-xd
Copy link

ners-xd commented Nov 28, 2024

Describe the bug

When using Find all references on any string, I get a grievous error in Deltarune LTS.

Reproducing steps

  1. Open Deltarune 1.16/1.17 (or any 2022.0 project maybe?)
  2. Try to use Find all references on any String

Setup Details

  1. UndertaleModTool 0.6.1.0 release
  2. Windows 11 Pro 26100.2454
  3. DELTARUNE Chapter 1&2 v1.17
    image
@ners-xd ners-xd added the bug Something isn't working label Nov 28, 2024
@colinator27
Copy link
Member

Likely duplicate of #1946

@maxiterr1
Copy link

It should have been fixed with the latest bleeding edge release (https://github.com/UnderminersTeam/UndertaleModTool/releases/tag/bleeding-edge).

@ners-xd
Copy link
Author

ners-xd commented Dec 2, 2024

It should have been fixed with the latest bleeding edge release (https://github.com/UnderminersTeam/UndertaleModTool/releases/tag/bleeding-edge).

It is not. It's also a different error this time
(Tried on Bleeding Edge e1f5d22 from a few minutes ago)
image

@colinator27
Copy link
Member

Ah, so it looks like this may be an LTS-specific problem. PredicateForVersion has no knowledge of the LTS branch, so it thinks the game is a 2023+ game, when it is in fact not, so it then tries to access particle systems that don't exist.

@vrad-exe
Copy link

Still an issue on the latest bleeding edge build

colinator27 added a commit that referenced this issue Mar 9, 2025
@colinator27
Copy link
Member

Fixed on the underanalyzer branch, so the fix will be merged into the main tool once that gets merged in (which should hopefully be soon, now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants