Add navlet tests

Author: Simrayz

tests/integration/web/navlets_test.py

@@ -1,11 +1,11 @@
-from unittest.mock import patch
+from unittest.mock import Mock, patch
 
 import pytest
 from django.test.client import RequestFactory
 from django.urls import reverse
 
 from nav.models.profiles import Account, AccountDashboard, AccountNavlet
-from nav.web.navlets import add_navlet, modify_navlet
+from nav.web.navlets import add_navlet, modify_navlet, Navlet
 
 
 class TestAddUserNavletView:
@@ -103,6 +103,103 @@ def test_given_non_existing_navlet_then_return_error(self, client):
         assert b"This widget no longer exists" in response.content
 
 
+class TestNavletPost:
+    """Tests for the Navlet.post method."""
+
+    def test_when_no_form_supplied_it_should_return_400(self, admin_account, dashboard):
+        request = RequestFactory().post('/fake-url')
+        navlet = Navlet()
+        navlet.request = request
+        navlet.account_navlet = AccountNavlet(
+            account=admin_account,
+            dashboard=dashboard,
+            navlet='nav.web.navlets.alert.AlertWidget',
+            preferences={},
+        )
+
+        response = navlet.post(request)
+        assert response.status_code == 400
+        assert b'No form supplied' in response.content
+
+    def test_given_valid_form_it_should_save_preferences(
+        self, admin_account, dashboard
+    ):
+        request = RequestFactory().post('/fake-url')
+        navlet = Navlet()
+        navlet.request = request
+        navlet.account_navlet = AccountNavlet(
+            account=admin_account,
+            dashboard=dashboard,
+            navlet='nav.web.navlets.alert.AlertWidget',
+            preferences={},
+        )
+
+        # Mock valid form
+        mock_form = Mock()
+        mock_form.is_valid.return_value = True
+        mock_form.cleaned_data = {'test_pref': 'test_value'}
+
+        with patch.object(navlet, 'get') as mock_get:
+            mock_get.return_value = Mock()
+            navlet.post(request, form=mock_form)
+
+        assert navlet.account_navlet.preferences['test_pref'] == 'test_value'
+
+    def test_given_invalid_form_it_should_call_handle_error_response(
+        self, admin_account, dashboard
+    ):
+        request = RequestFactory().post('/fake-url')
+        navlet = Navlet()
+        navlet.request = request
+        navlet.account_navlet = AccountNavlet(
+            account=admin_account,
+            dashboard=dashboard,
+            navlet='nav.web.navlets.alert.AlertWidget',
+            preferences={},
+        )
+
+        # Mock invalid form
+        mock_form = Mock()
+        mock_form.is_valid.return_value = False
+
+        with patch.object(navlet, 'handle_error_response') as mock_handle_error:
+            mock_handle_error.return_value = Mock()
+            navlet.post(request, form=mock_form)
+            mock_handle_error.assert_called_once()
+
+
+class TestNavletHandleErrorResponse:
+    """Tests for the Navlet.handle_error_response method."""
+
+    def test_should_render_form_errors_in_context(self):
+        request = RequestFactory().post('/fake-url')
+        navlet = Navlet()
+
+        # Mock form with errors
+        mock_form = Mock()
+        mock_form.errors = {
+            'field1': ['Error message 1'],
+            'field2': ['Error message 2'],
+        }
+
+        with (
+            patch('nav.web.navlets.render') as mock_render,
+            patch.object(navlet, 'get_context_data') as mock_context,
+            patch.object(navlet, 'get_template_names') as mock_template,
+        ):
+            mock_render.return_value = Mock()
+            mock_context.return_value = {}
+            mock_template.return_value = 'test_template.html'
+
+            navlet.handle_error_response(request, mock_form)
+
+            # Verify render was called with errors flattened into context
+            context = mock_render.call_args[0][2]
+            assert 'errors' in context
+            assert 'Error message 1' in context['errors']
+            assert 'Error message 2' in context['errors']
+
+
 def _get_dashboard_url(dashboard: AccountDashboard):
     return reverse('add-user-navlet', args=[dashboard.id])
 

tests/integration/widget_test.py

@@ -130,6 +130,44 @@ def test_given_navlet_id_when_navlet_type_is_invalid_then_return_error_widget(
     assert navlet.title == "Error"
 
 
+def test_given_htmx_request_with_non_existent_navlet_id_then_return_htmx_error_response(
+    client, admin_account
+):
+    """
+    Tests that dispatcher returns HTMX error response for non-existent navlet ID
+    on HTMX requests
+    """
+    url = reverse('get-user-navlet', kwargs={'navlet_id': 999})
+    response = client.get(url, HTTP_HX_REQUEST='true')
+
+    assert response.status_code == 200
+    assert response.context['error_message'] == 'This widget does not exist'
+
+
+def test_given_htmx_request_with_unauthorized_navlet_then_return_htmx_error_response(
+    client, admin_account, non_admin_account
+):
+    """
+    Tests that dispatcher returns HTMX error response for unauthorized access
+    on HTMX requests
+    """
+    dashboard = AccountDashboard.objects.create(
+        account=non_admin_account, name="Private Dashboard", is_shared=False
+    )
+    private_navlet = AccountNavlet.objects.create(
+        navlet="nav.web.navlets.welcome.WelcomeNavlet",
+        account=non_admin_account,
+        dashboard=dashboard,
+    )
+
+    # Admin account tries to access non_admin_account's private navlet via HTMX
+    url = reverse('get-user-navlet', kwargs={'navlet_id': private_navlet.id})
+    response = client.get(url, HTTP_HX_REQUEST='true')
+
+    assert response.status_code == 200
+    assert response.context['error_message'] == 'Not authorized to view this widget'
+
+
 #
 # Fixtures
 #