Crash When Accessing SourceAssets Tab When Using Sprite Atlases With DXT5|BC3 Compression

[stefandee]

Steps to reproduce:

1. create a sprite atlas and override the compression to use DXT5|BC3 mode;
2. build the project;
3. access the last build report, open the SourceAssets tab, notice the crash (see stack trace below).

In my project, the asset that causes the crash is:
buildTimeAssetPath: 'Built-in Texture2D: sactx-0-256x128-DXT5|BC3-ui-sprite-atlas-fff07956'

Stack trace:
ArgumentException: Illegal characters in path.
System.IO.Path.GetFileName (System.String path) (at <695d1cc93cca45069c528c15c9fdd749>:0)
Unity.BuildReportInspector.BuildReportInspector.ShowAssets (System.Collections.Generic.IEnumerable`1[T] assets, System.Single& vPos, System.String fileFilter, System.String typeFilter) (at E:/Temp/unity/BuildReportInspector-master/com.unity.build-report-inspector/Editor/BuildReportInspector.cs:470)
Unity.BuildReportInspector.BuildReportInspector.DisplayAssetsView (System.Single vPos) (at E:/Temp/unity/BuildReportInspector-master/com.unity.build-report-inspector/Editor/BuildReportInspector.cs:606)
Unity.BuildReportInspector.BuildReportInspector.OnAssetsGUI () (at E:/Temp/unity/BuildReportInspector-master/com.unity.build-report-inspector/Editor/BuildReportInspector.cs:597)
Unity.BuildReportInspector.BuildReportInspector.OnInspectorGUI () (at E:/Temp/unity/BuildReportInspector-master/com.unity.build-report-inspector/Editor/BuildReportInspector.cs:213)
UnityEditor.UIElements.InspectorElement+<>c__DisplayClass59_0.b__0 () (at :0)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)

[monika-pociute]

Hey! Thanks for reporting this issue.

Could you please submit a ticket using Unity's Bug Reporter by going to "Help" > "Report a Bug..." in the Unity editor? Please make sure to include a reproduction project (if you're reporting the issue using a project that has this issue it should be automatically included) and the exact steps we need to follow to reproduce the issue. If you could attach a reproduction video that would be great as well!

This way we'll have a better way to reach out to you if we need any more help and to inform you about the progress of this issue.

After creating the ticket you'll get a confirmation email that will have your case's number. Please write that number here so we could keep track of this issue.

[SkowronskiAndrew]

Thanks for reporting, and thanks for your patience.

Based on your description this would be an exception, not a crash, which would break the display of the build report inspector when it tries to turn treat that string as a path to shorten it to a filepath.

I'm not sure if i'll be able to reproduce that specific case but a fix should be simple to avoid the expection.