Skip to content

Commit 60b198d

Browse files
authored
FIX: remove unneeded check that triggered NotImplementedException for Usage bindings (#1625)
1 parent 9867e6e commit 60b198d

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

Packages/com.unity.inputsystem/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ however, it has to be formatted properly to pass verification tests.
2424
- Fixed Switch Pro, DualShock 4, DualSense gamepads becoming current on PC/macOS when no controls are changing ([case ISXB-223](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-223))).
2525
- Fixed an issue that made OnScreenStick unusable when used in conjunction with PlayerInput in Auto-Switch devices mode, or with any code that changes user/device pairing on unsued device activity being detected ([case ISXB-48](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-48)).
2626
- Fixed issue where input events were being suppressed during interactive action rebinding even when when their controls were excluded ([case ISXB-367](https://issuetracker.unity3d.com/issues/mouse-position-and-mouse-click-input-not-recognized-when-rebinding-is-active)).
27+
- Removed unneeded check that could trigger a NotImplementedException when binding to a Usage (e.g. Submit) ([case ISXB-373](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-373)).
2728
- Display a warning instead of throwing a NotImplementedException when loading binding overrides from json when some of the entries have become outdated ([case ISXB-375](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-375)).
2829

2930
### Actions

Packages/com.unity.inputsystem/InputSystem/Controls/InputControlPath.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -901,11 +901,6 @@ private static TControl MatchControlsRecursive<TControl>(InputControl control, s
901901
TControl lastMatch;
902902
if (path[indexInPath] == '{')
903903
{
904-
////TODO: support scavenging a subhierarchy for usages
905-
if (!ReferenceEquals(control.device, control))
906-
throw new NotImplementedException(
907-
"Matching usages inside subcontrols instead of at device root");
908-
909904
// Usages are kind of like entry points that can route to anywhere else
910905
// on a device's control hierarchy and then we keep going from that re-routed
911906
// point.

0 commit comments

Comments
 (0)