Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible methods for further development of vcf_filter UnitTest #24

Open
Jiu9Shen opened this issue Aug 10, 2018 · 2 comments
Open

Possible methods for further development of vcf_filter UnitTest #24

Jiu9Shen opened this issue Aug 10, 2018 · 2 comments

Comments

@Jiu9Shen
Copy link
Contributor

No description provided.

@Jiu9Shen Jiu9Shen changed the title Possible methods for further vcf_filter UnitTest Possible methods for further development of vcf_filter UnitTest Aug 10, 2018
@Jiu9Shen
Copy link
Contributor Author

One test can be performed by setting parameters to filter out all SNPs, then it will be much easier to check files generated from different format.

@laceysanderson
Copy link
Member

For each file format we should have a check that the file generated is of the expected format. I would create a helper method in your class for each format: like checkABHformatCompliance($file). Then you can call this function within your existing tests.

Also, the advantage of a testing suite is it can do much more intensive checks. I would do checks like: if I say filter "Only include Bi-allelic SNPs " that all the SNPs in the output file are bi-allelic and that you get the same number of SNPs after filtering that you do when this is done on the command-line. I would do this for all filter criteria, for all formats. Remember to use helper methods & arguements rather then copy/paste code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants