You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #39 introduced repetitive code in files: includes/vcf_filter.trpdownload.genotype_matrix.inc and includes/vcf_filter.trpdownload.hapmap.inc
For easier maintainability, it would be ideal to add a single function to the api instead. Alternatively, there already exists the api function vcf_filter_read_VCF_into_array() which may be suitable in this case.
See my comment from the review process here: #39 (review)
The text was updated successfully, but these errors were encountered:
Additionally, we need to switch over to using the api function because it uses the PL. This is currently causing discrepancies between output formats using the API function (ABH) and those which don't (HAPMAP, Genotype Matrix).
PR #39 introduced repetitive code in files: includes/vcf_filter.trpdownload.genotype_matrix.inc and includes/vcf_filter.trpdownload.hapmap.inc
For easier maintainability, it would be ideal to add a single function to the api instead. Alternatively, there already exists the api function vcf_filter_read_VCF_into_array() which may be suitable in this case.
See my comment from the review process here: #39 (review)
The text was updated successfully, but these errors were encountered: