Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repetitive code should be moved into a function for easier maintainability #48

Open
carolyncaron opened this issue Aug 9, 2019 · 1 comment

Comments

@carolyncaron
Copy link
Member

PR #39 introduced repetitive code in files: includes/vcf_filter.trpdownload.genotype_matrix.inc and includes/vcf_filter.trpdownload.hapmap.inc

For easier maintainability, it would be ideal to add a single function to the api instead. Alternatively, there already exists the api function vcf_filter_read_VCF_into_array() which may be suitable in this case.

See my comment from the review process here: #39 (review)

@laceysanderson
Copy link
Member

Additionally, we need to switch over to using the api function because it uses the PL. This is currently causing discrepancies between output formats using the API function (ABH) and those which don't (HAPMAP, Genotype Matrix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants