1C-Company#103 Экстернализация сообщений

Author: VAGoncharov

bundles/com.e1c.ssl.bsl/.settings/org.eclipse.core.resources.prefs

@@ -1,2 +1,3 @@
 eclipse.preferences.version=1
+encoding//src/com/e1c/ssl/bsl/check/messages_ru.properties=UTF-8
 encoding/<project>=UTF-8

bundles/com.e1c.ssl.bsl/src/com/e1c/ssl/bsl/check/Messages.java

@@ -0,0 +1,40 @@
+/*******************************************************************************
+ * Copyright (C) 2023, 1C-Soft LLC and others.
+ *
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *
+ * Contributors:
+ *     1C-Soft LLC - initial API and implementation
+ *******************************************************************************/
+
+package com.e1c.ssl.bsl.check;
+
+import org.eclipse.osgi.util.NLS;
+
+/**
+ * The Class Messages.
+ * @author Vadim Goncharov
+ */
+public class Messages
+    extends NLS
+{
+    private static final String BUNDLE_NAME = "com.e1c.ssl.bsl.check.messages"; //$NON-NLS-1$
+    
+    public static String UsersRolesAvailableRolesExistCheck_description;
+    public static String UsersRolesAvailableRolesExistCheck_Role_not_exist;
+    public static String UsersRolesAvailableRolesExistCheck_title;
+    
+    static
+    {
+        // initialize resource bundle
+        NLS.initializeMessages(BUNDLE_NAME, Messages.class);
+    }
+
+    private Messages()
+    {
+    }
+}

bundles/com.e1c.ssl.bsl/src/com/e1c/ssl/bsl/check/UsersRolesAvailableRolesExistCheck.java

@@ -90,8 +90,8 @@ public String getCheckId()
     protected void configureCheck(CheckConfigurer builder)
     {
         //TODO добавить extension CommonSenseCheckExtension
-        builder.title("Users.RolesAvailabel() role exist") //TODO add NLS String
-            .description("Users.RolesAvailabel() role exist") //TODO add NLS String
+        builder.title(Messages.UsersRolesAvailableRolesExistCheck_title)
+            .description(Messages.UsersRolesAvailableRolesExistCheck_description)
             .complexity(CheckComplexity.NORMAL)
             .severity(IssueSeverity.MAJOR)
             .issueType(IssueType.WARNING)
@@ -135,8 +135,7 @@ protected void check(Object object, ResultAcceptor resultAcceptor, ICheckParamet
             String fqn = topObjectFqnGenerator.generateStandaloneObjectFqn(ROLE, role);
             if (scope.getSingleElement(qualifiedNameConverter.toQualifiedName(fqn)) == null)
             {
-                //TODO add NLS String
-                String message = MessageFormat.format("Role {0} not exist", role);
+                String message = MessageFormat.format(Messages.UsersRolesAvailableRolesExistCheck_Role_not_exist, role);
                 resultAcceptor.addIssue(message, literal, STRING_LITERAL__LINES);
             }
 

bundles/com.e1c.ssl.bsl/src/com/e1c/ssl/bsl/check/messages.properties

@@ -0,0 +1,19 @@
+#Generated by ResourceBundle Editor (http://essiembre.github.io/eclipse-rbe/)
+###############################################################################
+# Copyright (C) 2023, 1C-Soft LLC and others.
+#
+# This program and the accompanying materials are made
+# available under the terms of the Eclipse Public License 2.0
+# which is available at https://www.eclipse.org/legal/epl-2.0/
+#
+# SPDX-License-Identifier: EPL-2.0
+#
+# Contributors:
+#     1C-Soft LLC - initial API and implementation
+###############################################################################
+
+UsersRolesAvailableRolesExistCheck_Role_not_exist = Role {0} not exist
+
+UsersRolesAvailableRolesExistCheck_description = Users.RolesAvailabel() - role exist
+
+UsersRolesAvailableRolesExistCheck_title = Users.RolesAvailabel() - role exist

bundles/com.e1c.ssl.bsl/src/com/e1c/ssl/bsl/check/messages_ru.properties

@@ -0,0 +1,19 @@
+#Generated by ResourceBundle Editor (http://essiembre.github.io/eclipse-rbe/)
+###############################################################################
+# Copyright (C) 2023, 1C-Soft LLC and others.
+#
+# This program and the accompanying materials are made
+# available under the terms of the Eclipse Public License 2.0
+# which is available at https://www.eclipse.org/legal/epl-2.0/
+#
+# SPDX-License-Identifier: EPL-2.0
+#
+# Contributors:
+#     1C-Soft LLC - initial API and implementation
+###############################################################################
+
+UsersRolesAvailableRolesExistCheck_Role_not_exist = Роль {0} не существует
+
+UsersRolesAvailableRolesExistCheck_description = Пользователи.РолиДоступны() - роль существует
+
+UsersRolesAvailableRolesExistCheck_title = Пользователи.РолиДоступны() - роль существует