More fixes for dax manager REDCap issues (#499)

Update dax_manager to use cached data from instance settings redcap project

Author: bud42

dax/dax_manager.py

@@ -534,9 +534,7 @@ def set_last_build_start(self, project):
             response = self._redcap.import_records([rec])
             assert 'count' in response
         except Exception as e:
-            err = 'redcap import failed'
-            LOGGER.info(err)
-            LOGGER.info(e)
+            LOGGER.info(f'REDCap import failed:{e}')
         except AssertionError as e:
             err = 'redcap import failed'
             LOGGER.info(e)
@@ -825,7 +823,7 @@ def run(self):
                 LOGGER.info(f'rcq update:{_projects}')
                 rcq.update(
                     self._rcq,
-                    self._redcap,
+                    self.settings_manager._instance_settings,
                     build_enabled=False, 
                     launch_enabled=self.is_enabled_launch(),
                     projects=_projects)
@@ -910,7 +908,7 @@ def run(self):
     def rcq_update(self):
         rcq.update(
             self._rcq,
-            self._redcap,
+            self.settings_manager._instance_settings,
             build_enabled=False, 
             launch_enabled=self.is_enabled_launch(),
             projects=self.settings_manager.project_names())
@@ -954,7 +952,7 @@ def run_rcq_build(self, projects):
             LOGGER.warn(f'failed to get lock, cannot build rcq:{lock_file}')
             return []
 
-        instance_settings = rcq._load_instance_settings(self._redcap)
+        instance_settings = self.settings_manager._instance_settings
         yaml_dir = instance_settings['main_processorlib']
         with get_interface(host=self.xnat_host) as xnat:
             builder = rcq.TaskBuilder(self._rcq, xnat, yaml_dir)

dax/rcq/__init__.py

@@ -33,18 +33,13 @@
 # apply_updates()
 
 
-def update(rc, instances, build_enabled=True, launch_enabled=True, projects=None):
+def update(rc, instance_settings, build_enabled=True, launch_enabled=True, projects=None):
     logger.info('connecting to redcap')
     def_field = rc.def_field
 
     if projects is None:
         projects = [x[def_field] for x in rc.export_records(fields=[def_field])]
 
-    instance_settings = _load_instance_settings(instances)
-    if not instance_settings:
-        logger.debug('no settings found for this instance')
-        return
-
     logger.debug(f'instance_settings={instance_settings}')
 
     yamldir = instance_settings['main_processorlib']