Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Java used for running to remote_jdk #83

Open
lukaszwawrzyk opened this issue Jan 20, 2023 · 1 comment · Fixed by #91
Open

Configure Java used for running to remote_jdk #83

lukaszwawrzyk opened this issue Jan 20, 2023 · 1 comment · Fixed by #91
Assignees
@mikkoziel
Labels
development Problems or improvements for development of Bazel Steward maintenance Refactoring or tests

Comments

@lukaszwawrzyk
Copy link
Collaborator

This project should not depend on java in the system for development and running tests.
By default bazel uses remote_jdk (jdk that it downloads and stores somewhere) for building to have reproducible builds. However for running and tests it uses local_jdk, i.e. java installed in your system.
We should configure the project to use known java version (11? 17?) for both building and running.
@lukaszwawrzyk lukaszwawrzyk added maintenance Refactoring or tests development Problems or improvements for development of Bazel Steward labels Jan 20, 2023
@mikkoziel mikkoziel mentioned this issue Jan 25, 2023
Merged
@lukaszwawrzyk lukaszwawrzyk reopened this Jan 26, 2023
@lukaszwawrzyk
Copy link
Collaborator Author

Issue seems not to be resolved for @kamildoleglo setup. Maybe we need to explicitly specify some remotejdk_17 or something.

@mikkoziel mikkoziel mentioned this issue Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkoziel mikkoziel

Labels
development Problems or improvements for development of Bazel Steward maintenance Refactoring or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added .bazelrc file with configuration VirtusLab/bazel-steward
2 participants
@lukaszwawrzyk @mikkoziel