Skip to content

Commit 3d20ae5

Browse files
committed
pkp#11252 Show only reviews in the last round in action-required view
1 parent ab866a9 commit 3d20ae5

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

api/v1/_submissions/PKPBackendSubmissionsController.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,8 @@ public function getReviewAssignments(Request $illuminateRequest): JsonResponse
374374
foreach ($illuminateRequest->query() as $param => $val) {
375375
switch ($param) {
376376
case 'actionRequired':
377-
$collector->filterByActionRequiredByReviewer(true);
377+
$collector->filterByActionRequiredByReviewer(true)
378+
->filterByLastReviewRound(true);
378379
break;
379380
case 'active':
380381
$collector->filterByActive(true);

classes/submission/Repository.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -1095,7 +1095,7 @@ protected function mapDashboardViews(Collection $types, Context $context, User $
10951095
->filterByStatus([PKPSubmission::STATUS_QUEUED]);
10961096
return new DashboardView(
10971097
$key,
1098-
in_array(Role::ROLE_ID_AUTHOR, $selectedRoleIds) ? __('submission.list.revisionsSubmitted') : __('submission.dashboard.view.revisionsSubmitted'),
1098+
in_array(Role::ROLE_ID_AUTHOR, $selectedRoleIds) ? __('submission.list.revisionsSubmitted') : __('submission.dashboard.view.revisionsSubmitted'),
10991099
[Role::ROLE_ID_SITE_ADMIN, Role::ROLE_ID_MANAGER, Role::ROLE_ID_SUB_EDITOR, Role::ROLE_ID_ASSISTANT, Role::ROLE_ID_AUTHOR],
11001100
$canAccessUnassignedSubmission
11011101
? $collector
@@ -1123,7 +1123,8 @@ protected function mapDashboardViews(Collection $types, Context $context, User $
11231123
Repo::reviewAssignment()->getCollector()
11241124
->filterByReviewerIds([$user->getId()])
11251125
->filterByContextIds([$context->getId()])
1126-
->filterByActionRequiredByReviewer(true),
1126+
->filterByActionRequiredByReviewer(true)
1127+
->filterByLastReviewRound(true),
11271128
'reviewerAssignments',
11281129
['actionRequired' => true]
11291130
);

0 commit comments

Comments
 (0)