🐛 Fix for & or = in the body:

- replace either with a `_` for the purpose of the signature
- keep the original arguments in the request
- TODO: need to test with inbound requests

Author: tjlytle

src/Client/Signature.php

@@ -43,11 +43,16 @@ public function __construct(array $params, $secret)
         //sort params
         ksort($this->signed);
 
+        $signed = [];
+        foreach ($this->signed as $key => $value) {
+            $signed[$key] = str_replace(array("&", "="), "_", $value);
+        }
+
         //create base string
-        $base = '&'.urldecode(http_build_query($this->signed));
+        $base = '&'.urldecode(http_build_query($signed));
 
         //append the secret
-        $base .=  $secret;
+        $base .= $secret;
 
         //create hash
         $this->signed['sig'] = md5($base);

test/Client/SignatureTest.php

@@ -85,7 +85,15 @@ public function signatures()
                 'to' => '14849970568',
                 'type' => 'text',
                 'sig' => '83c052a82906ec7c116e16f6d92f7eee'
-            ), 'my_secret_key_for_testing')
+            ), 'my_secret_key_for_testing'),
+            array('17f5e3b22f778ec73464c01d180e9d0f', array(
+                'api_key' => 'not_a_key',
+                'from' => '12192259404',
+                'text' => '14843472194',
+                'text' => 'Test&test=something',
+                'timestamp' => '1490638615',
+                'to' => '14843472194',
+            ), 'my_secret_key_for_testing'),
         );
     }