fixing linter errors

Author: johnny-quesada-developer

.verdaccio/config.yml

@@ -1,7 +1,10 @@
 import globals from 'globals';
+import baseConfig from '../eslint.config.mjs';
 
 export default [
   {
+    ...baseConfig,
+
     files: ['**/*.{ts,tsx,js,jsx}'],
     languageOptions: {
       globals: globals.node,

backend/eslint.config.mjs

@@ -2,12 +2,12 @@ import nx from '@nx/eslint-plugin';
 import baseConfig from '../eslint.config.mjs';
 
 export default [
-  // inherit everything from root
-  ...baseConfig,
-
   // add Nx React presets for this app
   ...nx.configs['flat/react'],
 
+  // inherit everything from root
+  ...baseConfig,
+
   {
     files: ['**/*.{ts,tsx,js,jsx}'],
     settings: {

frontend/eslint.config.mjs

@@ -46,7 +46,7 @@ describe('AppConfigContext', () => {
     };
 
     vi.spyOn(global, 'fetch').mockResolvedValue({
-      json: async () => mockConfig,
+      json: () => mockConfig,
       headers: {
         get: () => 'application/json',
       },
@@ -80,6 +80,8 @@ describe('AppConfigContext', () => {
     expect(appConfig.isAppConfigLoaded).toBe(false);
     expect(loadAppConfig()).rejects.toThrow('mocking a failure to fetch');
 
+    // test will fail without the await act
+    // eslint-disable-next-line @typescript-eslint/await-thenable
     await act(() => {
       rerender();
     });
@@ -113,6 +115,8 @@ describe('AppConfigContext', () => {
 
     expect(loadAppConfig()).rejects.toThrow('No valid JSON found, using default config');
 
+    // test will fail without the await act
+    // eslint-disable-next-line @typescript-eslint/await-thenable
     await act(() => {
       rerender();
     });

frontend/src/Context/AppConfig/AppConfigContext.spec.tsx

@@ -212,7 +212,7 @@ describe('useBackgroundPublisher', () => {
       });
     });
 
-    it('handles permission denial', async () => {
+    it('handles permission denial', () => {
       mockedInitPublisher.mockReturnValue(mockPublisher);
 
       const { result } = renderHook(() => useBackgroundPublisher());
@@ -227,7 +227,7 @@ describe('useBackgroundPublisher', () => {
       expect(mockSetAccessStatus).toBeCalledWith(DEVICE_ACCESS_STATUS.REJECTED);
     });
 
-    it('does not throw on older, unsupported browsers', async () => {
+    it('does not throw on older, unsupported browsers', () => {
       mockQuery.mockImplementation(() => {
         throw new Error('Whoops');
       });

frontend/src/Context/BackgroundPublisherProvider/useBackgroundPublisher/useBackgroundPublisher.spec.tsx

@@ -23,7 +23,7 @@ export type BackgroundPublisherContextType = {
   publisherVideoElement: HTMLVideoElement | HTMLObjectElement | undefined;
   destroyBackgroundPublisher: () => void;
   toggleVideo: () => void;
-  changeBackground: (backgroundSelected: string) => void;
+  changeBackground: (backgroundSelected: string) => Promise<void>;
   backgroundFilter: VideoFilter | undefined;
   localVideoSource: string | undefined;
   accessStatus: string | null;
@@ -87,7 +87,7 @@ const useBackgroundPublisher = (): BackgroundPublisherContextType => {
    */
   const changeBackground = useCallback(
     (backgroundSelected: string) => {
-      applyBackgroundFilter({
+      return applyBackgroundFilter({
         publisher: backgroundPublisherRef.current,
         backgroundSelected,
         setUser: undefined,
@@ -222,11 +222,13 @@ const useBackgroundPublisher = (): BackgroundPublisherContextType => {
     setIsVideoEnabled(!isVideoEnabled);
   };
 
+  // eslint-disable-next-line react-hooks/refs
   return {
     initBackgroundLocalPublisher,
     isPublishing,
     isVideoEnabled,
     destroyBackgroundPublisher,
+    // eslint-disable-next-line react-hooks/refs
     publisher: backgroundPublisherRef.current,
     publisherVideoElement,
     toggleVideo,

frontend/src/Context/BackgroundPublisherProvider/useBackgroundPublisher/useBackgroundPublisher.tsx

@@ -203,7 +203,7 @@ describe('usePreviewPublisher', () => {
       });
     });
 
-    it('handles permission denial', async () => {
+    it('handles permission denial', () => {
       mockedInitPublisher.mockReturnValue(mockPublisher);
 
       const { result } = renderHook(() => usePreviewPublisher());
@@ -218,7 +218,7 @@ describe('usePreviewPublisher', () => {
       expect(mockSetAccessStatus).toBeCalledWith(DEVICE_ACCESS_STATUS.REJECTED);
     });
 
-    it('does not throw on older, unsupported browsers', async () => {
+    it('does not throw on older, unsupported browsers', () => {
       mockQuery.mockImplementation(() => {
         throw new Error('Whoops');
       });

frontend/src/Context/PreviewPublisherProvider/usePreviewPublisher/usePreviewPublisher.spec.tsx

@@ -32,7 +32,7 @@ export type PreviewPublisherContextType = {
   destroyPublisher: () => void;
   toggleAudio: () => void;
   toggleVideo: () => void;
-  changeBackground: (backgroundSelected: string) => void;
+  changeBackground: (backgroundSelected: string) => Promise<void>;
   backgroundFilter: VideoFilter | undefined;
   localAudioSource: string | undefined;
   localVideoSource: string | undefined;
@@ -104,7 +104,7 @@ const usePreviewPublisher = (): PreviewPublisherContextType => {
    */
   const changeBackground = useCallback(
     (backgroundSelected: string) => {
-      applyBackgroundFilter({
+      return applyBackgroundFilter({
         publisher: publisherRef.current,
         backgroundSelected,
         setUser,
@@ -317,12 +317,14 @@ const usePreviewPublisher = (): PreviewPublisherContextType => {
     }
   };
 
+  // eslint-disable-next-line react-hooks/refs
   return {
     isAudioEnabled,
     initLocalPublisher,
     isPublishing,
     isVideoEnabled,
     destroyPublisher,
+    // eslint-disable-next-line react-hooks/refs
     publisher: publisherRef.current,
     publisherVideoElement,
     toggleAudio,

frontend/src/Context/PreviewPublisherProvider/usePreviewPublisher/usePreviewPublisher.tsx

@@ -120,37 +120,37 @@ describe('usePublisher', () => {
 
   describe('changeBackground', () => {
     let result: ReturnType<typeof renderHook>['result'];
-    beforeEach(async () => {
+    beforeEach(() => {
       vi.mocked(initPublisher).mockImplementation(() => mockPublisher);
       result = renderHook(() => usePublisher()).result;
-      await act(async () => {
-        await (result.current as ReturnType<typeof usePublisher>).initializeLocalPublisher({});
+      act(() => {
+        (result.current as ReturnType<typeof usePublisher>).initializeLocalPublisher({});
       });
     });
 
-    it('applies low blur filter', async () => {
-      await act(async () => {
-        await (result.current as ReturnType<typeof usePublisher>).changeBackground('low-blur');
+    it('applies low blur filter', () => {
+      act(() => {
+        (result.current as ReturnType<typeof usePublisher>).changeBackground('low-blur');
       });
       expect(mockPublisher.applyVideoFilter).toHaveBeenCalledWith({
         type: 'backgroundBlur',
         blurStrength: 'low',
       });
     });
 
-    it('applies background replacement with image', async () => {
-      await act(async () => {
-        await (result.current as ReturnType<typeof usePublisher>).changeBackground('bg1.jpg');
+    it('applies background replacement with image', () => {
+      act(() => {
+        (result.current as ReturnType<typeof usePublisher>).changeBackground('bg1.jpg');
       });
       expect(mockPublisher.applyVideoFilter).toHaveBeenCalledWith({
         type: 'backgroundReplacement',
         backgroundImgUrl: expect.stringContaining('bg1.jpg'),
       });
     });
 
-    it('clears video filter for unknown option', async () => {
-      await act(async () => {
-        await (result.current as ReturnType<typeof usePublisher>).changeBackground('none');
+    it('clears video filter for unknown option', () => {
+      act(() => {
+        (result.current as ReturnType<typeof usePublisher>).changeBackground('none');
       });
       expect(mockPublisher.clearVideoFilter).toHaveBeenCalled();
     });

frontend/src/Context/PublisherProvider/usePublisher/usePublisher.spec.tsx

@@ -18,6 +18,7 @@ const usePublisherQuality = (publisher: Publisher | null): NetworkQuality => {
 
   const handleVideoDisabled = useCallback(() => {
     setQuality('bad');
+    // eslint-disable-next-line react-hooks/immutability
     user.issues.audioFallbacks += 1;
   }, [user]);