Pass 3 step 1 GCD audits

[blaufuss]

These audits should check at all DOMs have are working properly have a value of 1.0 for mean_atwd_charge and mean_fadc_charge

[blaufuss]

@gh999ic Please check that the "SLC only" doms are not lumped into the general bad doms list. They currently seem to have mean_fadc_charge = nan in 2024 run DB. I suspect they've always been this way

here's a list I just check for a 2024 run: 140733.

OMKey(7,34,0) SLC only
OMKey(7,43,0) SLC only
OMKey(28,10,0) SLC only
OMKey(34,16,0) SLC only
OMKey(36,3,0) SLC only
OMKey(36,14,0) SLC only
OMKey(36,20,0) SLC only
OMKey(36,28,0) SLC only
OMKey(36,29,0) SLC only
OMKey(39,8,0) SLC only
OMKey(45,24,0) SLC only
OMKey(46,53,0) SLC only
OMKey(50,58,0) SLC only
OMKey(53,59,0) SLC only
OMKey(53,60,0) SLC only
OMKey(55,11,0) SLC only
OMKey(60,26,0) SLC only
OMKey(62,26,0) SLC only
OMKey(72,33,0) SLC only
OMKey(72,34,0) SLC only
OMKey(72,35,0) SLC only
OMKey(72,36,0) SLC only
OMKey(72,37,0) SLC only
OMKey(72,43,0) SLC only
OMKey(86,11,0) SLC only

[gh999ic]

@gh999ic Please check that the "SLC only" doms are not lumped into the general bad doms list. They currently seem to have mean_fadc_charge = nan in 2024 run DB. I suspect they've always been this way

here's a list I just check for a 2024 run: 140733.

OMKey(7,34,0) SLC only OMKey(7,43,0) SLC only OMKey(28,10,0) SLC only OMKey(34,16,0) SLC only OMKey(36,3,0) SLC only OMKey(36,14,0) SLC only OMKey(36,20,0) SLC only OMKey(36,28,0) SLC only OMKey(36,29,0) SLC only OMKey(39,8,0) SLC only OMKey(45,24,0) SLC only OMKey(46,53,0) SLC only OMKey(50,58,0) SLC only OMKey(53,59,0) SLC only OMKey(53,60,0) SLC only OMKey(55,11,0) SLC only OMKey(60,26,0) SLC only OMKey(62,26,0) SLC only OMKey(72,33,0) SLC only OMKey(72,34,0) SLC only OMKey(72,35,0) SLC only OMKey(72,36,0) SLC only OMKey(72,37,0) SLC only OMKey(72,43,0) SLC only OMKey(86,11,0) SLC only

how can I make a list like that?

[blaufuss]

this is just a list of DOMs that have nan values in mean_fadc_charge. I then did a dive into live.icecube.wisc.edu to see why these doms would not have these values. These SLC only doms were ignored by Dawn's calibration scripts...

[gh999ic]

I originally ran the I3GCDAuditor module which omits checking any doms
in the BadDomsList key by default.

Then I made the following changes to BadDomListModule, I3GCDAuditor, and gcd_generation in PR #3892:

The BadDomListModule could already accept a list of custom OMKeys,
and I added an option to only use those.

In I3GCDAuditor, I added info and warn msgs if a DOM has a nan value for mean ATWD or FADC charge.
The info messages are printed before any other checks.
The warn messages are printed only after all other checks for that DOM pass.
So a nan warn message indicates that DOM should change its value from nan to 1.

In gcd_generation, I added functions run_gcd_audit_pass3 and get_nan_doms.
The former runs the GCD audit with the custom list of 7 OMKeys that are excluded in online processing.
The latter parses the GCD audit for nan warning messages.

The full workflow is in PR #28
scripts/icetray/step1/pass3_update_gcd_chargecorr.py

1. audit old gcd file
2. parse audit to get nan warning messages
3. make new gcd , changing nan values in warning messages to 1.
4. audit new gcd file

Does this sound reasonable?

I already used all of the above to create a new set of historical GCD files at
/data/ana/IceCube/20??/filtered/OnlinePass3.2
This set also includes .inaudit and .outaudit files for each GCD.