Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong name the assembly #49

Open
daiplusplus opened this issue Feb 18, 2023 · 1 comment
Open

Strong name the assembly #49

daiplusplus opened this issue Feb 18, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@daiplusplus
Copy link

daiplusplus commented Feb 18, 2023

I had a nasty runtime error just now in a strong-named project targeting .NET Framework 4.8 that uses this NuGet package, as strong-named assemblies transitively require all referenced assemblies to also have strong-names.

I can work-around it with the StrongNamer hack package, but I'd prefer it if this assembly were strong-named properly in the first place.

Microsoft explicitly recommend that libraries distributed as NuGet packages should be strong-named:

You should strong name your open-source .NET libraries. Strong naming an assembly ensures the most people can use it, and strict assembly loading only affects .NET Framework.

@daiplusplus
Copy link
Author

I have added strong-naming in my branch here: https://github.com/daiplusplus/ExhaustiveMatching/tree/dev/2011-11-strong-naming

Because this branch builds off my current PR, I'll submit this as a PR once my existing PR is merged.

@WalkerCodeRanger WalkerCodeRanger added the enhancement New feature or request label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants