CLI: setupWitness and QueryEnd double-open same Reger LMDB path in same process -- fails on LMDB 2.x

[ryan-hansen]

• indirecting.setupWitness creates a Reger for the witness hab, then instantiates QueryEnd
• QueryEnd.init allocates another Reger with the same name/path

LMDB only allows one open environment per path per process. The older bindings didn’t fully enforce this, but LMDB 2.x with current py-lmdb raises lmdb.Error: The environment '…' is already open in this process, so kli witness demo and any other path using setupWitness will crash at startup.

This issue is not specific to shell scripts; it will happen in any environment using setupwitness with lmdb 2

[pfeairheller]

The fix here is to pass the Reger object created on line 54 of setupWitness to the constructor of QueryEnd on line 93 instead of creating a new one in QueryEnd init method.

In addition, I recommend searching the code base for instances of the Reger constructor and ensure that any hierarchy of objects created in methods similar to setupWitness only share an instance of Reger and don't allow for None to be passed in, creating a new one that will trigger this issue again.

[daidoji]

This happens on version v1.2.12 as well from a clean virtualenv and installation.