Merge pull request #51 from WillCodeForCats/50-platform-solaredge_modbus_multi-does-not-generate-unique-ids

Check for duplicate meter serial numbers

Author: WillCodeForCats

custom_components/solaredge_modbus_multi/hub.py

@@ -87,19 +87,37 @@ async def async_init_solaredge(self) -> None:
 
             if self._detect_meters:
                 try:
-                    self.meters.append(SolarEdgeMeter(inverter_unit_id, 1, self))
+                    new_meter_1 = SolarEdgeMeter(inverter_unit_id, 1, self)
+                    for meter in self.meters:
+                        if new_meter_1.serial == meter.serial:
+                            _LOGGER.error(f"Duplicate serial {new_meter_1.serial}. Ignoring meter 1 on inverter ID {inverter_unit_id}")
+                            raise RuntimeError(f"Duplicate meter 1 serial {new_meter_1.serial}")
+                    
+                    self.meters.append(new_meter_1)
                     _LOGGER.debug(f"Found meter 1 on inverter ID {inverter_unit_id}")
                 except:
                     pass
 
                 try:
-                    self.meters.append(SolarEdgeMeter(inverter_unit_id, 2, self))
+                    new_meter_2 = SolarEdgeMeter(inverter_unit_id, 2, self)
+                    for meter in self.meters:
+                        if new_meter_2.serial == meter.serial:
+                            _LOGGER.error(f"Duplicate serial {new_meter_2.serial}. Ignoring meter 2 on inverter ID {inverter_unit_id}")
+                            raise RuntimeError(f"Duplicate meter 2 serial {new_meter_2.serial}")
+                    
+                    self.meters.append(new_meter_2)
                     _LOGGER.debug(f"Found meter 2 on inverter ID {inverter_unit_id}")
                 except:
                     pass
 
                 try:
-                    self.meters.append(SolarEdgeMeter(inverter_unit_id, 3, self))
+                    new_meter_3 = SolarEdgeMeter(inverter_unit_id, 3, self)
+                    for meter in self.meters:
+                        if new_meter_3.serial == meter.serial:
+                            _LOGGER.error(f"Duplicate serial {new_meter_3.serial}. Ignoring meter 3 on inverter ID {inverter_unit_id}")
+                            raise RuntimeError(f"Duplicate meter 3 serial {new_meter_3.serial}")
+                    
+                    self.meters.append(new_meter_3)
                     _LOGGER.debug(f"Found meter 3 on inverter ID {inverter_unit_id}")
                 except:
                     pass