-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle documentation templates #14
Comments
The function metadata should be fetched with template functions built into the theme. Examples will be provided on ticket #14
Sample template functions as mentioned in commit beb7630 are at https://gist.github.com/paulgibbs/5693065 |
I thought about this some more. I'd suggest creating a bunch of new Git repos for different parts of this project, and using a subtree or a submodule (don't know what I'm talking about here -- I mean like an svn external) to glue them all together. There's some distinct parts already:
And I'd add:
Ideally I would like to merge the last two bullets into one plugin, like I described originally in this ticket. |
Ideally, what I'd like is two parts:
In practice, separating the generator out isn't going to be possible until wp-cli/wp-cli#424 is handled. In any case, IMO the plugin should include the importer, the post type registration and the templates. So, path from where we are to where we want to end up:
The template functions look good, but since we're 5.3+, let's go full namespacing. I'm thinking |
Putting aside the technical implementation details for now, I broadly agree, but for the record, I absolutely do not want to loose the ability to generate and import data via WP-CLI. Over the next couple of weeks, I'll put together a bare-bones plugin with how I'm thinking the templating should work, and will then make that available for you to review. |
+1 for some templates. |
If templates are to be included in the plugin, these should be overideable by templates in the theme. Gamajo Template Loader handles the logic needed, which just leaves a simple subclass that defines the directories used to hold the templates. |
On the fence about templates. For now templates tags are in the process of settling in and cleaning up. Personally I am fine with leaving templates to DIY it's up to theme. Bundling is worth revisiting once (if :) we have several people running different sites on it and see commonalities in template needed. |
Has any progress been made on this? I'd love to see some override-able templates (similar to bbPress or WooCommerce) that would allow theme devs to see how things are intended to work by default, and then customize as necessary. |
Not so far. Honestly I think there is still depressing amount of internal cleanup to get through (which is completely stalled) before getting to figuring out generic reuse and public APIs here. |
I've been thinking about the problem of requiring people to build templates to display the data that this importer generates. Right now, it's not ideal:
We could bundle template files with the plugin and tell users to copy into their theme, but as these will be full templates, we'll quickly find people complaining that the HTML/CSS structure is different from their themes' templates, and so on.
Proposal: create a plugin that registers the post types, and use bbPress/BuddyPress theme compatibility techniques to enable an out-of-the-box documentation experience for any site.
The text was updated successfully, but these errors were encountered: