-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow periods in @since taxonomy terms slugs #36
Comments
Could you adapt Mark's plugin? I'd rather it stay modular, rather than us hacking around in WP for everything. |
You mean do a patch for WP-Parser, or me just implement it for my own use case? |
The latter; WP doesn't support it out of the box, and I prefer the "do one thing and do it well" philosophy rather than the kitchen-sink philosophy. :) |
I am all for better URLs, however in my opinion parser already butts in too much into site. Right now we cannot even keep it enabled on DevHub outside of parsing process running because it messes things up. So my current opinion is - whatever data parser creates it should remain viable data without it. URLs shouldn't break if parser plugin is no longer present/enabled. It would, however, be beneficial to have a snippet around that easily provides clean "dot" URLs on top of parser data, just not as its default functionality. |
So long as there's a filter right before the slug is inserted, then it should be trivial for an external plugin to look for slugs matching of |
Yeah, this is definitely something I want for developer.wordpress.org, but whether it is actually included as part of the parser itself is not a big issue. I think it'd actually be easier to do this on runtime and rewrite taxonomy=wp-parser-since&term=3.8.0 to query for 3-8-0 instead. |
Seems like this has been done in devhub reference. Anyone cares to comment on and/or document the process? It still doesn't seem like something Parser itself should do. |
I agree with both @Rarst and @nacin ... much better to handle it on the theme side. On the DevHub theme, looks like we just use simple replacements for source file and since version permalinks:
Though it occurs to me that alone just handles changing term links. I can't find anything about parsing the actual value of x.x.x vs x-x-x at runtime. |
http://txfx.net/wordpress-plugins/periods-in-titles/ allows periods in post and term slugs. I use it at, for example, http://genesischangelog.com/2.0.2 .
It would be good if periods would be allowed for the
@since
taxonomy terms, so docs.example.com/since/1-0-0 would become a friendlier looking and naturally quicker to type docs.example.com/since/1.0.0 .The text was updated successfully, but these errors were encountered: