Skip to content

Commit 567f6a3

Browse files
committed
Upgrade to go 1.18 to get generics
Originally wanted to upgrade to 1.25, but test woulds pass anymore. Upgrading to 1.18 allows us to use generics while preventing any additional maintenance as all tests still passes.
1 parent 18d7737 commit 567f6a3

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

.github/workflows/tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
runs-on: ubuntu-latest
1919
strategy:
2020
matrix:
21-
go: [ '1.15', 'stable' ]
21+
go: [ '1.18', 'stable' ]
2222
name: Tests on Go ${{ matrix.go }}
2323
steps:
2424
- name: Checkout Repo

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.16-alpine3.13 AS build-go
1+
FROM golang:1.18-alpine AS build-go
22

33
ARG GIT_SSH_KEY
44
ARG KNOWN_HOSTS_CONTENT

go.mod

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,16 @@
11
module github.com/Workiva/go-datastructures
22

3-
go 1.15
3+
go 1.18
44

55
require (
66
github.com/stretchr/testify v1.7.0
77
github.com/tinylib/msgp v1.1.5
88
)
9+
10+
require (
11+
github.com/davecgh/go-spew v1.1.0 // indirect
12+
github.com/philhofer/fwd v1.1.1 // indirect
13+
github.com/pmezard/go-difflib v1.0.0 // indirect
14+
github.com/stretchr/objx v0.1.0 // indirect
15+
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c // indirect
16+
)

0 commit comments

Comments
 (0)