Skip to content

modesetting: Use don't skip planes that are not on the current crtc #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −3
Open

modesetting: Use don't skip planes that are not on the current crtc #1503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4449062
modesetting: Use don't skip planes that are not on the current crtc
stefan11111 Nov 29, 2025
072c5ee
modesetting: don't leak memory for the cursor plane if libdrm is too old
stefan11111 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions hw/xfree86/drivers/video/modesetting/drmmode_display.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2685,16 +2685,28 @@ drmmode_crtc_create_planes(xf86CrtcPtr crtc, int num)
/* Get the SIZE_HINT dimensions, if supported. */
int size_hint = drmmode_prop_get_value(&tmp_props[DRMMODE_PLANE_SIZE_HINTS], props, 0);
drmmode_populate_cursor_size_hints(drmmode, drmmode_crtc, size_hint);
#endif
drmModeFreePlane(kplane);
drmModeFreeObjectProperties(props);
#endif
continue;
}
case DRMMODE_PLANE_TYPE_PRIMARY:
{
/* If this plane is not on this crtc, skip it */
/* Prefer planes that are on this CRTC already */
if (plane_crtc != drmmode_crtc->mode_crtc->crtc_id) {
drmModeFreePlane(kplane);
/* If this is the only plane we have, it's the best we have */
if (!best_plane) {
best_plane = plane_id;
best_kplane = kplane;
blob_id = drmmode_prop_get_value(&tmp_props[DRMMODE_PLANE_IN_FORMATS],
props, 0);
async_blob_id = drmmode_prop_get_value(&tmp_props[DRMMODE_PLANE_IN_FORMATS_ASYNC],
props, 0);
drmmode_prop_info_copy(drmmode_crtc->props_plane, tmp_props,
DRMMODE_PLANE__COUNT, 1);
} else {
drmModeFreePlane(kplane);
}
drmModeFreeObjectProperties(props);
continue;
}
Expand Down