[AIEX] Global Combiner - Pointer Modifier

[F-Stuckmann]

This implements a global combiner for determining post increments or offset Memory Instructions.
The following is still work in progress:

• There are 3 CombineResult classes with similarities that should be combined to one. This also includes adding the new CombineResult Class to the AIECombiners.
• The gain function of the combiners should be more general and moved to AIEGlobalCombiner. Depending on the QoR results, there may be some finetuning in the cost calculation.
• Matching rules should be provided by .td, instead of being implemented as classes

That being said, the structure in AIEPtrModPass , AIEGlobalCombiner and BaseInstrInfo should be stable and close to the final version.

[andcarminati]

I see this warning:

 warning: definition of implicit copy assignment operator for 'CombinerSolution' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
  CombinerSolution(const CombinerSolution &Other) = default;
  ^
../llvm/lib/Target/AIE/AIEGlobalCombiner.cpp:278:22: note: in implicit copy assignment operator for 'llvm::AIE::CombinerSolution' first required here
        BestSolution = Current;
                     ^
1 warning generated.

[F-Stuckmann]

Once #460 is merged, the placeholder commit can be removed

[F-Stuckmann]

I removed the placeholder PR commit

[martien-de-jong]

To stop it from haunting you.
It looks good to me.

[andcarminati]

I see this warning:

 warning: definition of implicit copy assignment operator for 'CombinerSolution' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
  CombinerSolution(const CombinerSolution &Other) = default;
  ^
../llvm/lib/Target/AIE/AIEGlobalCombiner.cpp:278:22: note: in implicit copy assignment operator for 'llvm::AIE::CombinerSolution' first required here
        BestSolution = Current;
                     ^
1 warning generated.

Hi @F-Stuckmann , this comment was not addressed, could you please address this in a follow-up PR? Thank you!

[andcarminati]

This seems to be unused!