Prevent wasteful processing on BaseBuilder

kazuki43zoo · kazuki43zoo · commit 92cef489facd · 2019-12-19T01:25:11.000+09:00
Fixes mybatisgh-1786
diff --git a/src/main/java/org/apache/ibatis/builder/BaseBuilder.java b/src/main/java/org/apache/ibatis/builder/BaseBuilder.java
@@ -102,7 +102,7 @@ protected Object createInstance(String alias) {
       return null;
     }
     try {
-      return resolveClass(alias).getDeclaredConstructor().newInstance();
+      return clazz.getDeclaredConstructor().newInstance();
     } catch (Exception e) {
       throw new BuilderException("Error creating instance. Cause: " + e, e);
     }

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ protected Object createInstance(String alias) {`
`102`	`102`	`return null;`
`103`	`103`	`}`
`104`	`104`	`try {`
`105`		`- return resolveClass(alias).getDeclaredConstructor().newInstance();`
	`105`	`+ return clazz.getDeclaredConstructor().newInstance();`
`106`	`106`	`} catch (Exception e) {`
`107`	`107`	`throw new BuilderException("Error creating instance. Cause: " + e, e);`
`108`	`108`	`}`