Skip to content

Depend only on required parts of AWS SDK #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lewisd32 opened this issue Nov 16, 2016 · 5 comments
Open

Depend only on required parts of AWS SDK #7

lewisd32 opened this issue Nov 16, 2016 · 5 comments
Assignees

Comments

@lewisd32
Copy link

This project depends on the entire AWS SDK:
https://github.com/Yleisradio/aws-maven/blob/master/pom.xml#L43-L44
It's been modularized (I'm not sure which version that started, but probably between the version in the spring-projects/aws-maven and this one) so you can depend only on the part you need.
Depending on the aws-java-sdk meta-package results in downloading a LOT of jars that presumably aws-maven doesn't actually need.

That dependency can be replaced by the dependencies within aws-java-sdk that are required by aws-maven, and it shouldn't affect functionality. ;)

(Thanks for the fork, by the way. I need the support for credentials from instance-profiles, and sts credentials.)

@huima
Copy link

huima commented Nov 16, 2016

Thanks. We have just been lazy and not doing that earlier .-) Will put on todo-list.

@huima huima self-assigned this Nov 16, 2016
@lewisd32
Copy link
Author

I'll submit a PR if I get a chance to try this before you. :)

@huima
Copy link

huima commented Apr 4, 2017

Finally started to work on this. Will publish new versions soon.

@huima
Copy link

huima commented Apr 4, 2017

Did this already, not pushed into github yet. Problem is leiningen dependency to older jackson currently. Untill new release is done, current version is better to be used by clojure coders. technomancy/leiningen#2215

@huima
Copy link

huima commented Apr 25, 2017

This is done and released with 1.4.1. For leiningen use, still need to wait next release technomancy/leiningen#2269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants