Addressing post-hoc PR feedback on #174 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in the C++ side where the error is not set correctly on a “high s” signature. The Rust side had mirrored this bug, but this eliminates the bug in the Rust.
This doesn’t seem to have any effect on the semantics, as the DER-formatted signature includes lengths that ensure it will ignore extra bytes, but the C++ code removes the extra byte, so the Rust should as well.
Co-authored-by: Daira-Emma Hopwood <[email protected]>
nuttycom
previously approved these changes
Feb 6, 2025
This now splits slices and returns the remaining pieces rather than modifying the arguments.
conradoplg
previously approved these changes
Feb 14, 2025
nuttycom
previously approved these changes
Feb 19, 2025
daira
reviewed
Feb 20, 2025
daira
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
utACK. Search for 🤔 in https://github.com/ZcashFoundation/zcash_script/pull/174/files to see comments there that are not addressed here.
daira
approved these changes
Feb 24, 2025
|
Since one of the requirements on this repo is that all comments must be resolved, I pushed two more commits that address the outstanding comments here and on #174, respectively. |
nuttycom
approved these changes
Feb 25, 2025
|
@conradoplg I think that this now has enough ACKs to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.