null vars (#17)

* use null variables instead of empty strings

* use null variables instead of empty strings

Author: glitchcrab

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Correct conditional logic.
+- Use null vars instead of strings.
 
 ## [1.2.0] - 2022-11-27
 

instance.tf

@@ -3,8 +3,8 @@ resource "proxmox_vm_qemu" "proxmox_instance" {
   desc = var.pve_instance_description
   vmid = var.vmid
 
-  clone      = var.pxe_boot == true ? "" : var.clone
-  full_clone = var.pxe_boot == true ? false : var.full_clone
+  clone      = var.pxe_boot == true ? null : var.clone
+  full_clone = var.pxe_boot == true ? null : var.full_clone
   pxe        = var.pxe_boot
   boot       = var.boot
 
@@ -36,10 +36,10 @@ resource "proxmox_vm_qemu" "proxmox_instance" {
     }
   }
 
-  os_type  = var.pxe_boot == true ? "" : var.os_type
-  cicustom = var.pxe_boot == true ? "" : var.cicustom
+  os_type  = var.pxe_boot == true ? null : var.os_type
+  cicustom = var.pxe_boot == true ? null : var.cicustom
   # example: "user=${var.citemplate_storage}:${var.snippet_dir}/user-${var.snippet_file_base},network=${var.citemplate_storage}:${var.snippet_dir}/network-${var.snippet_file_base}"
-  cloudinit_cdrom_storage = var.pxe_boot == true ? "" : var.cloudinit_cdrom_storage
+  cloudinit_cdrom_storage = var.pxe_boot == true ? null : var.cloudinit_cdrom_storage
 
   searchdomain = var.searchdomain
   nameserver   = var.nameserver

variables.tf

@@ -14,13 +14,13 @@ variable "vmid" {
 }
 
 variable "clone" {
-  default     = ""
+  default     = null
   description = "Name of the template to clone (ignored when pxe_boot is true)."
   type        = string
 }
 
 variable "full_clone" {
-  default     = false
+  default     = null
   description = "Create a full clone; if false, a linked clone will be created (ignored when pxe_boot is true)."
   type        = bool
 }
@@ -89,7 +89,7 @@ variable "disks" {
 }
 
 variable "os_type" {
-  default     = ""
+  default     = null
   description = "Type of OS for preprovisioning."
   type        = string
 }
@@ -107,20 +107,20 @@ variable "snippet_file_base" {
 }
 
 variable "cicustom" {
-  default     = ""
+  default     = null
   description = "Path(s) to cloud-init config files (ignored when pxe_boot is true)."
   type        = string
 }
 
 variable "citemplate_storage" {
-  default     = "local"
+  default     = null
   description = "Name of the storage containing the cloud-init snippets (ignored when pxe_boot is true)."
   type        = string
 }
 
 variable "cloudinit_cdrom_storage" {
-  default     = "local-lvm"
-  description = "Name of the storage to create the cloud-init image in."
+  default     = null
+  description = "Name of the storage to create the cloud-init image in (e.g. local-lvm)."
   type        = string
 }