Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slices of ValuationResult should return ValuationResult #629

Closed
mdbenito opened this issue Nov 14, 2024 · 1 comment · Fixed by #660
Closed

Slices of ValuationResult should return ValuationResult #629

mdbenito opened this issue Nov 14, 2024 · 1 comment · Fixed by #660
Assignees
@mdbenito
Labels
breaking-change Changes to the API good first issue Good for newcomers
Milestone
v0.10.0

Comments

@mdbenito
Copy link
Collaborator

As of 0.9.2 they return lists of ValueItems, which is unintuitive
@mdbenito mdbenito added breaking-change Changes to the API good first issue Good for newcomers labels Nov 14, 2024
@mdbenito mdbenito self-assigned this Mar 9, 2025
@mdbenito mdbenito added this to the v0.10.0 milestone Mar 9, 2025
@mdbenito
Copy link
Collaborator Author

mdbenito commented Mar 9, 2025 •
edited
Loading

v0.10 is the time to do this

mdbenito added a commit that referenced this issue Mar 9, 2025
@mdbenito
Close #629: Slices of results are results. Make equality comparison m…
a2d6446 
…ore natural, add tests
@mdbenito mdbenito mentioned this issue Mar 9, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdbenito mdbenito

Labels
breaking-change Changes to the API good first issue Good for newcomers
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

Fix/result slicing aai-institute/pyDVL
1 participant
@mdbenito