Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate proptypes validation based on breakpoints and known flexbox options #5

Open
2 of 3 tasks
aaronvanston opened this issue Apr 5, 2017 · 3 comments
Open
2 of 3 tasks

Comments

@aaronvanston
Copy link
Owner

aaronvanston commented Apr 5, 2017

  • Move the current various Flexbox property options from their respective component into a helper function.

  • Generate the prop validation based on these options and the breakpoints passed in.

  • Enables dynamic validation based on the amount of breakpoints used.

@aaronvanston aaronvanston changed the title Generate Prop validation based on breakpoints and known flexbox options Generate proptypes validation based on breakpoints and known flexbox options Apr 5, 2017
@aaronvanston
Copy link
Owner Author

This feature is now mostly introduced with #62. All functionality is in place however there is no validation and these custom breakpoints are not stripped form the element when generating.

@billykwok
Copy link

Do you still need help? Just discovered this amazingly neat flexbox grid framework and would like to see how I could help make it fully support a dynamic number of breakpoints.

@aaronvanston
Copy link
Owner Author

@billykwok Thanks! Yes any help would be appreciated!

I'd like to separate out common proptype validations into files similar to the utils/helpers. These proptypes should generate based off the theme, so if a user sets an xl breakpoint etc it understands to apply the same proptype validations as the others etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants