Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect mapping of loop to source #60

Open
aayasin opened this issue Jan 23, 2024 · 0 comments
Open

Incorrect mapping of loop to source #60

aayasin opened this issue Jan 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@aayasin
Copy link
Owner

aayasin commented Jan 23, 2024

The hottest 2 loops of SVT-AV1:

# g "^loop#[12]:" SVT-AV1-n8-base-t75-janysave_type-er20c4ppp-c7000001.perf.data.info.log 
loop#2: [ip: 0x977f00, hotness:   7464, srcline: highbd_convolve_2d_avx2.c;111, size: 47, imix-ID: 9200, back: 0x977fdf, entry-block: 0x977e60, attributes: vec128-int;vec256-int, inner: 0, outer: 0, Conds: 0, op-jcc-mf: 1, mov-op-mf: 0, ld-op-mf: 0, lea: 0, cmov: 0, load: 9, store: 2, rmw: 0, lock: 0, prefetch: 0, zcnt: 0]
loop#1: [ip: 0x977d80, hotness:   9605, srcline: highbd_convolve_2d_avx2.c;111, size: 46, imix-ID: 4120, back: 0x977e53, entry-block: -, attributes: vec128-int;vec256-int, inner: 0, outer: 0, Conds: 2, op-jcc-mf: 2, mov-op-mf: 1, ld-op-mf: 0, lea: 0, cmov: 0, load: 4, store: 1, rmw: 0, lock: 0, prefetch: 0, zcnt: 0]

are incorrectly mapped to same loop at line 111, see source at
https://gitlab.com/AOMediaCodec/SVT-AV1/-/blob/master/Source/Lib/Common/ASM_AVX2/highbd_convolve_2d_avx2.c?ref_type=heads#L111

Prevent buggy mapping first (nullify last label after use) then fix most likely require perf tool change.

@aayasin aayasin added the bug Something isn't working label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant