Skip to content

Commit b89e4fc

Browse files
committed
New exceptions
1 parent a8d456a commit b89e4fc

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

src/zcl_package_json.clas.abap

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,9 @@ CLASS zcl_package_json IMPLEMENTATION.
143143
DATA(issues) = zcl_package_json_valid=>check( manifest ).
144144

145145
IF issues IS NOT INITIAL.
146-
zcx_error=>raise( |Invalid package json:\n{ concat_lines_of( table = issues sep = |\n| ) }| ).
146+
RAISE EXCEPTION TYPE zcx_error_text
147+
EXPORTING
148+
text = |Invalid package json:\n{ concat_lines_of( table = issues sep = |\n| ) }|.
147149
ENDIF.
148150

149151
ENDMETHOD.
@@ -159,7 +161,9 @@ CLASS zcl_package_json IMPLEMENTATION.
159161
METHOD constructor.
160162

161163
IF zcl_package_json_valid=>is_valid_sap_package( package ) = abap_false.
162-
zcx_error=>raise( |Invalid package: { package }| ).
164+
RAISE EXCEPTION TYPE zcx_error_text
165+
EXPORTING
166+
text = |Invalid package: { package }|.
163167
ENDIF.
164168

165169
me->package = package.
@@ -268,7 +272,7 @@ CLASS zcl_package_json IMPLEMENTATION.
268272
result = sort_manifest( manifest ).
269273

270274
CATCH zcx_ajson_error INTO DATA(error).
271-
zcx_error=>raise_with_text( error ).
275+
RAISE EXCEPTION TYPE zcx_error_prev EXPORTING previous = error.
272276
ENDTRY.
273277

274278
ENDMETHOD.
@@ -358,7 +362,7 @@ CLASS zcl_package_json IMPLEMENTATION.
358362

359363
result = ajson->stringify( 2 ).
360364
CATCH zcx_ajson_error INTO DATA(error).
361-
zcx_error=>raise_with_text( error ).
365+
RAISE EXCEPTION TYPE zcx_error_prev EXPORTING previous = error.
362366
ENDTRY.
363367

364368
ENDMETHOD.

src/zcl_package_json_valid.clas.locals_imp.abap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ CLASS lcl_validate IMPLEMENTATION.
7070
INSERT |Invalid bugs URL: { manifest-bugs-url }| INTO TABLE result.
7171
ENDIF.
7272

73+
" This should not be a URL to an html project page that you put in your browser. It's for computers.
74+
" Example: git+https://github.com/abapPM/abapPM.git
7375
IF zcl_package_json_valid=>is_valid_url( manifest-repository-url ) = abap_false.
7476
INSERT |Invalid repository URL: { manifest-repository-url }| INTO TABLE result.
7577
ENDIF.

0 commit comments

Comments
 (0)