Skip to content

Commit 72c0566

Browse files
committed
lispy-clojure.clj (use-package): Remove
* le-clojure.el (lispy-cider-jack-in-dependencies): Default to nil. Fixes #615
1 parent ca14d62 commit 72c0566

File tree

3 files changed

+29
-66
lines changed

3 files changed

+29
-66
lines changed

le-clojure.el

+7-9
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,7 @@
118118
(remove-hook 'nrepl-connected-hook
119119
'lispy--clojure-eval-hook-lambda))
120120

121-
(defvar lispy-cider-jack-in-dependencies
122-
'(("me.raynes/fs" "1.4.6")
123-
("compliment" "0.3.11")
124-
("com.cemerick/pomegranate" "0.4.0")
125-
("org.tcrawley/dynapath" "0.2.5")
126-
("nrepl" "0.8.2")))
121+
(defvar lispy-cider-jack-in-dependencies nil)
127122

128123
(defvar cider-jack-in-cljs-dependencies)
129124
(defvar cider-jack-in-dependencies)
@@ -439,9 +434,12 @@ Besides functions, handles specials, keywords, maps, vectors and sets."
439434
cider-jdk-src-paths
440435
"\n "))))
441436
(lispy--eval-clojure-cider sources-expr)))
442-
(when lispy-clojure-middleware-tests
443-
(lispy-message
444-
(lispy--eval-clojure-cider "(lispy.clojure/run-lispy-tests)")))))))
437+
(let ((test-fname (expand-file-name "lispy-clojure-test.clj"
438+
lispy-site-directory)))
439+
(when (and lispy-clojure-middleware-tests
440+
(file-exists-p test-fname))
441+
(lispy-message
442+
(lispy--eval-clojure-cider (format "(load-file \"%s\")" test-fname)))))))))
445443

446444
(defun lispy-flatten--clojure (_arg)
447445
"Inline a Clojure function at the point of its call."

lispy-clojure-test.clj

+15-16
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,20 @@
1818
;; see <http://www.gnu.org/licenses/>.
1919

2020
(ns lispy-clojure-test
21-
(:use [clojure.test :only [is deftest]]
22-
[lispy.clojure :only [add-location-to-defn
23-
add-location-to-def
24-
debug-step-in
25-
dest
26-
expand-home
27-
get-func-args
28-
get-func-args-def
29-
guess-intent
30-
object-members
31-
position
32-
reader=
33-
reval
34-
symbol-function]]))
21+
(:require
22+
[clojure.test :refer [is deftest]]
23+
[lispy.clojure :refer [add-location-to-defn
24+
add-location-to-def
25+
debug-step-in
26+
dest
27+
get-func-args
28+
get-func-args-def
29+
guess-intent
30+
object-members
31+
position
32+
reader=
33+
reval
34+
symbol-function]]))
3535

3636
(deftest get-func-args-test
3737
(is (= (get-func-args (symbol-function 'string?) 1) '[x]))
@@ -76,7 +76,7 @@
7676

7777
(deftest debug-step-in-test
7878
(is (= (debug-step-in
79-
'(expand-home (str "/foo" "/bar")))
79+
'(lispy.clojure/expand-home (str "/foo" "/bar")))
8080
{:path "/foo/bar"}))
8181
(is
8282
(=
@@ -145,7 +145,6 @@
145145
["/foo/bar.clj" 42]))))
146146

147147
(deftest guess-intent-test
148-
(is (= (guess-intent '(defproject) nil) '(lispy.clojure/fetch-packages)))
149148
(is (= (guess-intent 'x '[x y]) 'x))
150149
(is (= (guess-intent '*ns* '*ns*) '*ns*))
151150
(is (= (guess-intent '(+ 1 2) '[(+ 1 2) (+ 3 4) (+ 5 6)])

lispy-clojure.clj

+7-41
Original file line numberDiff line numberDiff line change
@@ -21,26 +21,12 @@
2121
(:require [clojure.repl :as repl]
2222
[clojure.pprint]
2323
[clojure.java.io :as io]
24-
[clojure.string :as str]
25-
[cemerick.pomegranate :refer [add-dependencies]])
24+
[clojure.string :as str])
2625
(:import
2726
(java.io File LineNumberReader InputStreamReader
2827
PushbackReader FileInputStream)
2928
(clojure.lang RT)))
3029

31-
(defn use-package [name version]
32-
(add-dependencies
33-
:coordinates [[name version]]
34-
:repositories (merge cemerick.pomegranate.aether/maven-central
35-
{"clojars" "https://clojars.org/repo"})
36-
:classloader (. (. (. Compiler/LOADER deref) getParent) getParent)))
37-
38-
(defn expand-file-name [name dir]
39-
(. (io/file dir name) getCanonicalPath))
40-
41-
(use-package 'me.raynes/fs "1.4.6")
42-
(require '[me.raynes.fs :as fs])
43-
4430
(defmacro xcond
4531
"Common Lisp style `cond'.
4632
@@ -58,23 +44,11 @@ malleable to refactoring."
5844
(xcond
5945
~@(next clauses)))))))
6046

61-
(defn fetch-packages []
62-
(xcond ((fs/exists? "deps.edn")
63-
(println "fixme"))
64-
((fs/exists? "project.clj")
65-
(let [deps (->> (slurp "project.clj")
66-
(read-string)
67-
(drop 3)
68-
(partition 2)
69-
(map vec)
70-
(into {})
71-
:dependencies)]
72-
(doseq [[name ver] deps]
73-
(use-package name ver))))
74-
(:else
75-
(throw
76-
(ex-info "Found no project.clj or deps.edn"
77-
{:cwd fs/*cwd*})))))
47+
(defn file-exists? [f]
48+
(. (io/file f) exists))
49+
50+
(defn expand-file-name [name dir]
51+
(. (io/file dir name) getCanonicalPath))
7852

7953
(defn expand-home
8054
[path]
@@ -431,8 +405,6 @@ malleable to refactoring."
431405
expr
432406
(let [idx (position expr context reader=)]
433407
(xcond
434-
((#{'defproject} (first expr))
435-
`(fetch-packages))
436408
((nil? idx)
437409
expr)
438410
;; [x |(+ 1 2) y (+ 3 4)] => {:x 3}
@@ -532,7 +504,7 @@ malleable to refactoring."
532504
(clojure.core/str "error: " ~ 'e)))))))
533505

534506
(defn file->elisp [f]
535-
(if (fs/exists? f)
507+
(if (file-exists? f)
536508
f
537509
(. (io/resource f) getPath)))
538510

@@ -560,9 +532,3 @@ malleable to refactoring."
560532
(fn [v]
561533
(let [m (meta v)]
562534
(str v "\n" (:arglists m) "\n" (:doc m))))))))
563-
564-
(defn run-lispy-tests []
565-
(let [dd (fs/parent (:file (meta #'use-package)))
566-
fname (java.io.File. dd "lispy-clojure-test.clj")]
567-
(when (fs/exists? fname)
568-
(load-file (str fname)))))

0 commit comments

Comments
 (0)