Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time offsets are not round number of minutes #5

Open
ac2cz opened this issue May 15, 2019 · 1 comment
Open

Time offsets are not round number of minutes #5

ac2cz opened this issue May 15, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@ac2cz
Copy link
Owner

ac2cz commented May 15, 2019

Looking at the example display on the web page I figured out that the tic marks are every 12 minutes and 51 seconds.

Would it be a simple improvement to round your “scale multiplier result” so that the tic marks always came out in multiples of an even number of minutes. With ten minutes being the default, then one could scale to integer multiples of that even number?

@ac2cz ac2cz added the bug Something isn't working label May 15, 2019
@ac2cz
Copy link
Owner Author

ac2cz commented Jun 15, 2019

This needs to be fixed in two chunks. The first piece is to change the label plotting to use a set "step" distance between each label e.g. 10 mins. That is implemented in V1.01. The labels are then a set distance apart but they are still not round numbers. e.g. two labels might be 16:10:35 and 16:10:45. They are odd values because they correspond to the actual position data that was calculated.

So the second change is to calculate the positions at round numbers. Currently we grab the current time and then calculate all of the positions out in to the future based in the step time. If we adjust the current time to be a round number of minutes and zero seconds, then we will create labels that have a round number of minutes. We need to make sure that we don't upset the calculation of positions in the circular buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant