simplify dp check on upload

Author: MontrealSergiy

BrainPortal/app/controllers/userfiles_controller.rb

@@ -538,9 +538,9 @@ def create #:nodoc:
     rack_tempfile_size = upload_stream.tempfile.size
 
     # Get the data provider for the destination files.
-    data_provider_id   = params[:data_provider_id]
-    @provider          = DataProvider.find(data_provider_id)
-    cb_notice "Provider not accessible by current user." unless @provider.can_be_accessed_by?(current_user)
+    data_provider_id = params[:data_provider_id]
+
+    DataProvider.find_accessible_by_user(params[:id], current_user)
 
     # Where we'll keep a copy in the spawn() below
     tmpcontentfile     = "/tmp/#{Process.pid}-#{rand(10000).to_s}-#{basename}" # basename's extension is used later on

BrainPortal/spec/controllers/userfiles_controller_spec.rb

@@ -263,10 +263,11 @@ class << file; attr_reader :tempfile; end
 
       before(:each) do
         session[:session_id] = 'session_id'
-        allow(controller).to receive(:current_user).and_return(admin)
-        allow(Message).to    receive(:send_message)
-        allow(File).to       receive(:delete)
-        allow(controller).to receive(:system)
+        allow(controller).to   receive(:current_user).and_return(admin)
+        allow(Message).to      receive(:send_message)
+        allow(File).to         receive(:delete)
+        allow(controller).to   receive(:system)
+        allow(DataProvider).to receive(:find_accessible_by_user).and_return([data_provider])
       end
 
       it "should redirect to index if the upload file is blank" do
@@ -300,7 +301,7 @@ class << file; attr_reader :tempfile; end
           end
 
           it "should display an error message" do
-            post :create, params: { :upload_file => mock_upload_stream, :archive => "save", userfile: userfile}
+            post :create, params: { :upload_file => mock_upload_stream, :archive => "save", userfile: userfile, :data_provider_id => data_provider.id}
             expect(flash[:error]).to match(/File .+ could not be added./)
           end
         end
@@ -327,7 +328,7 @@ class << file; attr_reader :tempfile; end
 
             it "should copy the file to the local cache" do
               expect(mock_userfile).to receive(:cache_copy_from_local_file)
-              post :create, params: {:upload_file => mock_upload_stream, :archive => "save", userfile: userfile}
+              post :create, params: {:upload_file => mock_upload_stream, :archive => "save", userfile: userfile, :data_provider_id => data_provider.id}
             end
           end