Skip to content

Check that an Interval is an interval #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alberto-paparella opened this issue Feb 17, 2025 · 2 comments · May be fixed by #48
Open

Check that an Interval is an interval #47

alberto-paparella opened this issue Feb 17, 2025 · 2 comments · May be fixed by #48
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alberto-paparella
Copy link
Member

As suggested in the to-do here, I suggest to check that an object of type Interval is, indeed, and interval, not only for debugging, i.e., x<y (or, more generally, <(x,y) != 0; theoretically, this naturally generalizes to the many-valued case thanks to the third axiom of many-valued linear orders, i.e., <(x,x) = 0). Hence, I simply suggest removing comment on line 132 and deleting line 131.

@alberto-paparella alberto-paparella added the enhancement New feature or request label Feb 17, 2025
@alberto-paparella alberto-paparella self-assigned this Feb 17, 2025
@alberto-paparella
Copy link
Member Author

Simply removing line 132 isn't enough, as it was an old constructor without type parameter T; instead, i updated the basic constructor, using a guard to improve readability. All tests pass and the code seem to follow the wanted behavior (notice how requesting that x>0 and x0). Anyhow, I request a review.

@alberto-paparella alberto-paparella added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 20, 2025
@alberto-paparella alberto-paparella removed their assignment Feb 20, 2025
@alberto-paparella
Copy link
Member Author

Please refer to #48 if you want to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant