Skip to content

Conversation

@zlayaAvocado
Copy link
Collaborator

@zlayaAvocado zlayaAvocado commented Nov 13, 2025

Adds inapplicable examples for the audio/video autoplay rule.
https://deploy-preview-2371--act-rules.netlify.app/standards-guidelines/act/rules/80f0bf/proposed/

Closes issue(s):

Need for Call for Review:
This will require a 1 week Call for Review


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@zlayaAvocado zlayaAvocado self-assigned this Nov 13, 2025
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 59976c1
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6924de1d89026400085a89ec
😎 Deploy Preview https://deploy-preview-2371--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zlayaAvocado zlayaAvocado marked this pull request as ready for review November 13, 2025 03:27
@zlayaAvocado zlayaAvocado added reviewers wanted Review Call 1 week Call for review for small changes labels Nov 13, 2025
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. Approving already.

@WilcoFiers WilcoFiers removed the Review Call 1 week Call for review for small changes label Nov 13, 2025
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with JYM's comments. I also found a problem with the applicability because of this. Interesting edge case here.

Comment on lines +184 to +189
This `video` element does not play for longer than 3 seconds.

```html
<video autoplay>
<source src="/test-assets/rabbit-video/video.mp4#t=8,10" type="video/mp4" />
<source src="/test-assets/rabbit-video/video.webm#t=8,10" type="video/webm" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's actually kind of tricky. The media resource has a duration of 13 seconds, but the video has a play time of 2 seconds. I think we'll need to update the applicability.

Something like:

- **play time**: the element has a [media resource][] that contains audio and that stops no more than 3 

**Note**: For most videos the start time is 0, and the stop time is the end of the video. In HTML the `t` parameter allows content authors to set the start and stop time of a video.

@Jym77 WDYT?

Copy link
Collaborator

@Jym77 Jym77 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point. Maybe phrasing the second sentence a bit more generically and with a link to specs:

This can be changed by authors, for example using a [temporal media fragment URI](https://www.w3.org/TR/media-frags/#naming-time) (`#t`) in the source URI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audio or video element avoids automatically playing audio: passed example 2 should be inapplicable

4 participants