Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

快捷审核git仓库审核,支持指定仓库分支 #2942

Closed
littleniannian opened this issue Mar 3, 2025 · 1 comment
Closed

快捷审核git仓库审核,支持指定仓库分支 #2942

littleniannian opened this issue Mar 3, 2025 · 1 comment
Assignees
Labels
feature publish-pre1 verified the issue all pr is verified
Milestone

Comments

@littleniannian
Copy link
Collaborator

littleniannian commented Mar 3, 2025

需求描述(Describe)

  • 需求目标:快捷审核git仓库审核,支持指定仓库分支
  • 需求预期:
    快捷审核中,使用git仓库审核时,除了填写仓库地址及用户名密码外,还支持选择需要审核的代码分支
    交互预期
    填写仓库信息后支持验证连通性
    验证失败时给出错误提示
    验证通过后才可选择分支
    没有验证连通性时,无法选择分支,移入时提示:请先验证仓库连通性
    默认展示默认分支
    支持下拉选择仓库已有分支
    支持手动输入分支名称(自动检验分支是否存在)
    Image

实现方案

  • 修改快捷审核接口: /v1/projects/default/sql_audit_records 增加formData字段git_branch_name
  • 新增测试git联通性接口: /v1/configurations/git/test
    请求体
{
	"git_http_url": "",
	"git_user_name": "",
	"git_user_password": ""
}

响应

{
	"is_connected_success": true,
	"branches": ["main", "feat_test"],
	"error_message": ""
}

变更影响面

受影响的模块或功能

  • 用户名/密码/git地址/分支变更为必填项
  • TODO: 代码里面要对账号密码做校验

外部引用的潜在问题或风险

版本兼容性

测试建议

@winfredLIN
Copy link
Collaborator

版本信息

UI: 4.2503.0-pre3-ee 8b6b2a5f
DMS: 4.2503.0-pre3-ee 6a09ffe1e1
SQLE: 4.2503.0-pre3-ee 066f8c6
Image

验证过程

验证连接
Image
选择git仓库
Image
审核成功
Image

@winfredLIN winfredLIN added the verified the issue all pr is verified label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature publish-pre1 verified the issue all pr is verified
Projects
None yet
Development

No branches or pull requests

3 participants