Skip to content

Bug: AMVF deleteLastVertex might be wrong #2380

Open
@andiwand

Description

@andiwand

https://github.com/acts-project/acts/blob/main/Core/include/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp#L549

I noticed that deleteLastVertex might be bugged.

  • we destroy the vertex candidate and access it again
  • we refit with the vertex we actually want to delete

I tried fixing it here https://github.com/andiwand/acts/tree/try-fix-amvf-delete-last-vertex

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't workingStale

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions