diff --git a/Procfile b/Procfile new file mode 100644 index 000000000..62e430aca --- /dev/null +++ b/Procfile @@ -0,0 +1 @@ +web: gunicorn 'app:create_app()' \ No newline at end of file diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..d86c78234 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -4,7 +4,6 @@ import os from dotenv import load_dotenv - db = SQLAlchemy() migrate = Migrate() load_dotenv() @@ -29,6 +28,12 @@ def create_app(test_config=None): db.init_app(app) migrate.init_app(app, db) - # Register Blueprints here + # Register blueprints + + from .task_routes import tasks_bp + app.register_blueprint(tasks_bp) + + from .goal_routes import goals_bp + app.register_blueprint(goals_bp) return app diff --git a/app/goal_routes.py b/app/goal_routes.py new file mode 100644 index 000000000..4a4d6c13a --- /dev/null +++ b/app/goal_routes.py @@ -0,0 +1,130 @@ +from flask import Blueprint, jsonify, request +from app import db +from app.models.goal import Goal +from sqlalchemy import asc +from app.task_routes import validate_task + +goals_bp = Blueprint("goals", __name__, url_prefix="/goals") + +def validate_goal(goal_id): + try: + goal_id = int(goal_id) + except ValueError: + return jsonify({"msg" : f"'{goal_id}' is invalid"}), 400 + + goal = Goal.query.get(goal_id) + if not goal: + return jsonify({"message" : f"Could not find '{goal_id}'"}), 404 + return goal + +def format_goal(goal): + return { + "goal": { + "id" : goal.goal_id, + "title" : goal.title + } + } + +@goals_bp.route('', methods=['POST']) +def create_goal(): + request_body = request.get_json() + + if "title" not in request_body: + return { + "details" : "Invalid data" + }, 400 + + new_goal = Goal( + title = request_body['title'] + ) + + db.session.add(new_goal) + db.session.commit() + + return format_goal(new_goal), 201 + +@goals_bp.route('', methods=['GET']) +def get_goals(): + goals = Goal.query.order_by(asc(Goal.title)).all() + goals_response = [] + + for goal in goals: + goals_response.append( + { + "id" : goal.goal_id, + "title" : goal.title + } + ) + return jsonify(goals_response), 200 + +@goals_bp.route('/', methods=['GET']) +def get_one_goal(goal_id): + goal = validate_goal(goal_id) + + if isinstance(goal, Goal): + return format_goal(goal), 200 + return goal + +@goals_bp.route('/', methods=['PUT']) +def update_goal(goal_id): + goal = validate_goal(goal_id) + request_body = request.get_json() + + if isinstance(goal, Goal): + goal.title = request_body["title"] + db.session.commit() + + return format_goal(goal), 200 + return goal + +@goals_bp.route('/', methods=['DELETE']) +def delete_goal(goal_id): + goal = validate_goal(goal_id) + if isinstance(goal, Goal): + db.session.delete(goal) + db.session.commit() + return { + "details" : f'Goal {goal_id} "{goal.title}" successfully deleted' + } + return goal + +@goals_bp.route('//tasks', methods=['POST']) +def assign_task_to_goal(goal_id): + goal = validate_goal(goal_id) + request_body = request.get_json() + + if isinstance(goal, Goal): + tasks = [] + for task_id in request_body['task_ids']: + task = validate_task(task_id) + task.goal_id = goal_id + tasks.append(task.task_id) + db.session.commit() + + return { + "id" : goal.goal_id, + "task_ids" : tasks + } + return goal + +@goals_bp.route('//tasks', methods=['GET']) +def get_tasks_of_goal(goal_id): + goal = validate_goal(goal_id) + + if isinstance(goal, Goal): + tasks = [] + for task in goal.tasks: + tasks.append({ + "id" : task.task_id, + "goal_id" : task.goal_id, + "title" : task.title, + "description" : task.description, + "is_complete" : bool(task.completed_at) + }) + + return { + "id" : goal.goal_id, + "title" : goal.title, + "tasks" : tasks + } + return goal \ No newline at end of file diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..1924d1f44 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -3,3 +3,5 @@ class Goal(db.Model): goal_id = db.Column(db.Integer, primary_key=True) + title = db.Column(db.String) + tasks = db.relationship("Task", back_populates="goal", lazy=True) diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..ca5572cc9 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -2,4 +2,9 @@ class Task(db.Model): - task_id = db.Column(db.Integer, primary_key=True) + task_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime, nullable=True) + goal_id = db.Column(db.Integer, db.ForeignKey('goal.goal_id'), nullable=True) + goal = db.relationship("Goal", back_populates="tasks") diff --git a/app/routes.py b/app/routes.py deleted file mode 100644 index 3aae38d49..000000000 --- a/app/routes.py +++ /dev/null @@ -1 +0,0 @@ -from flask import Blueprint \ No newline at end of file diff --git a/app/task_routes.py b/app/task_routes.py new file mode 100644 index 000000000..1e2d22598 --- /dev/null +++ b/app/task_routes.py @@ -0,0 +1,148 @@ +from flask import Blueprint, jsonify, request +from app import db +from app.models.task import Task +from sqlalchemy import desc, asc +from datetime import datetime +import requests +import os + +tasks_bp = Blueprint("tasks", __name__, url_prefix="/tasks") + + +def validate_task(task_id): + try: + task_id = int(task_id) + except ValueError: + return jsonify({"msg" : f"'{task_id}' is invalid"}), 400 + + task = Task.query.get(task_id) + if not task: + return jsonify({"message" : f"Could not find '{task_id}'"}), 404 + return task + +def format_task(task): + return { + "task" : + { + "is_complete" : bool(task.completed_at), + "description" : task.description, + "title" : task.title, + "id" : task.task_id, + "goal_id" : task.goal_id + } + } + +def push_complete_to_slack(task): + bot_token = os.environ.get("SLACK_BOT_TOKEN") + params = { + "channel" : "task-notifications", + "text" : f"Someone just completed the task {task.title}" + } + headers = {"authorization" : "Bearer " + bot_token} + requests.post("https://slack.com/api/chat.postMessage", params=params, headers=headers) + +@tasks_bp.route('', methods=['POST']) +def create_task(): + request_body = request.get_json() + + if "description" not in request_body or "title" not in request_body: + return { + "details" : "Invalid data" + }, 400 + + new_task = Task( + description = request_body['description'], + title = request_body['title'] + ) + + if "completed_at" in request_body: + new_task.completed_at = request_body['completed_at'] + + db.session.add(new_task) + db.session.commit() + + return format_task(new_task), 201 + +@tasks_bp.route('', methods=['GET']) +def get_tasks(): + sort_query = request.args.get("sort") + if sort_query == "desc": + tasks = Task.query.order_by(desc(Task.title)).all() + else: + tasks = Task.query.order_by(asc(Task.title)).all() + + tasks_response = [] + + for task in tasks: + tasks_response.append( + { + "is_complete" : bool(task.completed_at), + "description" : task.description, + "title" : task.title, + "id" : task.task_id + } + ) + + return jsonify(tasks_response), 200 + +@tasks_bp.route('/', methods=['GET']) +def get_one_task(task_id): + task = validate_task(task_id) + + if isinstance(task, Task): + return format_task(task), 200 + return task + +@tasks_bp.route('/', methods=['PUT']) +def update_task(task_id): + task = validate_task(task_id) + request_body = request.get_json() + + if isinstance(task, Task): + task.title = request_body["title"] + task.description = request_body["description"] + db.session.commit() + + if "completed_at" in request_body: + task.completed_at = request_body['completed_at'] + + return format_task(task), 200 + return task + +@tasks_bp.route('/', methods=['DELETE']) +def delete_task(task_id): + task = validate_task(task_id) + if isinstance(task, Task): + db.session.delete(task) + db.session.commit() + return { + "details" : f'Task {task_id} "{task.title}" successfully deleted' + } + return task + +@tasks_bp.route('//mark_complete', methods=['PATCH']) +def mark_complete(task_id): + task = validate_task(task_id) + + if isinstance(task, Task): + + task.completed_at = datetime.utcnow() + db.session.commit() + push_complete_to_slack(task) + return format_task(task), 200 + return task + +@tasks_bp.route('//mark_incomplete', methods=['PATCH']) +def mark_incomplete(task_id): + task = validate_task(task_id) + + if isinstance(task, Task): + task.completed_at = None + db.session.commit() + return format_task(task), 200 + return task + + + + + diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/0335b9a4e231_.py b/migrations/versions/0335b9a4e231_.py new file mode 100644 index 000000000..f0534cc9d --- /dev/null +++ b/migrations/versions/0335b9a4e231_.py @@ -0,0 +1,42 @@ +"""empty message + +Revision ID: 0335b9a4e231 +Revises: +Create Date: 2022-05-13 10:39:10.213626 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '0335b9a4e231' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.PrimaryKeyConstraint('goal_id') + ) + op.create_table('task', + sa.Column('task_id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.Column('goal_id', sa.Integer(), nullable=True), + sa.ForeignKeyConstraint(['goal_id'], ['goal.goal_id'], ), + sa.PrimaryKeyConstraint('task_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index 30ff414fe..4e3b88829 100644 --- a/requirements.txt +++ b/requirements.txt @@ -5,6 +5,7 @@ blinker==1.4 certifi==2020.12.5 chardet==4.0.0 click==7.1.2 +coverage==6.3.2 Flask==1.1.2 Flask-Migrate==2.6.0 Flask-SQLAlchemy==2.4.4 @@ -28,6 +29,7 @@ python-dotenv==0.15.0 python-editor==1.0.4 requests==2.25.1 six==1.15.0 +slack-sdk==3.16.1 SQLAlchemy==1.3.23 toml==0.10.2 urllib3==1.26.5 diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..9b8a555a8 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,6 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +12,6 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +30,6 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -46,12 +43,12 @@ def test_get_task(client, one_task): "id": 1, "title": "Go on my daily walk 🏞", "description": "Notice something new every day", - "is_complete": False + "is_complete": False, + "goal_id" : None } } -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -59,14 +56,10 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert response_body == {"message" : f"Could not find '1'"} + assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -83,7 +76,8 @@ def test_create_task(client): "id": 1, "title": "A Brand New Task", "description": "Test Description", - "is_complete": False + "is_complete": False, + "goal_id" : None } } new_task = Task.query.get(1) @@ -93,7 +87,6 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -110,7 +103,8 @@ def test_update_task(client, one_task): "id": 1, "title": "Updated Task Title", "description": "Updated Test Description", - "is_complete": False + "is_complete": False, + "goal_id" : None } } task = Task.query.get(1) @@ -119,7 +113,6 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -130,14 +123,10 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert response_body == {"message" : f"Could not find '1'"} + assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +141,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") + def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -160,16 +149,10 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - + assert response_body == {"message" : f"Could not find '1'"} assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +169,6 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ @@ -201,3 +183,4 @@ def test_create_task_must_contain_description(client): "details": "Invalid data" } assert Task.query.all() == [] + diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..7b662b0eb 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") + def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,6 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 959176ceb..5f55e66fc 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,6 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -36,13 +35,14 @@ def test_mark_complete_on_incomplete_task(client, one_task): "id": 1, "title": "Go on my daily walk 🏞", "description": "Notice something new every day", - "is_complete": True + "is_complete": True, + "goal_id" : None } } assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") + def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -56,13 +56,14 @@ def test_mark_incomplete_on_complete_task(client, completed_task): "id": 1, "title": "Go on my daily walk 🏞", "description": "Notice something new every day", - "is_complete": False + "is_complete": False, + "goal_id" : None } } assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") + def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -93,13 +94,13 @@ def test_mark_complete_on_completed_task(client, completed_task): "id": 1, "title": "Go on my daily walk 🏞", "description": "Notice something new every day", - "is_complete": True + "is_complete": True, + "goal_id" : None } } assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -113,13 +114,13 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): "id": 1, "title": "Go on my daily walk 🏞", "description": "Notice something new every day", - "is_complete": False + "is_complete": False, + "goal_id" : None } } assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -127,14 +128,11 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == {"message" : f"Could not find '1'"} + assert Task.query.all() == [] - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -142,16 +140,10 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert response_body == {"message" : f"Could not find '1'"} + assert Task.query.all() == [] -# Let's add this test for creating tasks, now that -# the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_with_valid_completed_at(client): # Act response = client.post("/tasks", json={ @@ -169,7 +161,8 @@ def test_create_task_with_valid_completed_at(client): "id": 1, "title": "A Brand New Task", "description": "Test Description", - "is_complete": True + "is_complete": True, + "goal_id" : None } } new_task = Task.query.get(1) @@ -179,9 +172,6 @@ def test_create_task_with_valid_completed_at(client): assert new_task.completed_at -# Let's add this test for updating tasks, now that -# the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_with_completed_at_date(client, completed_task): # Act response = client.put("/tasks/1", json={ @@ -199,7 +189,8 @@ def test_update_task_with_completed_at_date(client, completed_task): "id": 1, "title": "Updated Task Title", "description": "Updated Test Description", - "is_complete": True + "is_complete": True, + "goal_id" : None } } task = Task.query.get(1) diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..123f04e6c 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,8 @@ import pytest +from app.models.goal import Goal + -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +13,6 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +29,6 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +45,18 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") - # Assert - # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Test ---- + #Assert + assert response.status_code == 404 + assert response_body == {"message" : f"Could not find '1'"} + assert Goal.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +75,41 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title" : "Updated Goal Title" + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title", + } + } + goal = Goal.query.get(1) + assert goal.title == "Updated Goal Title" + -@pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title" : "Updated Goal Title" + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert response_body == {"message" : f"Could not find '1'"} + assert Goal.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -123,28 +125,20 @@ def test_delete_goal(client, one_goal): # Check that the goal was deleted response = client.get("/goals/1") assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert Goal.query.get(1) == None -@pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") - - # Act - # ---- Complete Act Here ---- + # Act + response = client.delete("/goals/1") + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert response_body == {"message" : f"Could not find '1'"} + assert Goal.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..ae79e0013 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") + def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,6 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +41,6 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -50,14 +48,10 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert response_body == {"message" : f"Could not find '1'"} + assert Goal.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +68,6 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -98,8 +91,6 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): ] } - -@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()