diff --git a/Procfile b/Procfile new file mode 100644 index 000000000..62e430aca --- /dev/null +++ b/Procfile @@ -0,0 +1 @@ +web: gunicorn 'app:create_app()' \ No newline at end of file diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..a96a339d9 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -12,6 +12,9 @@ def create_app(test_config=None): app = Flask(__name__) + + # app.config["SLACK_TOKEN"] = os.environ.get("SLACK_API_KEY") + app.config["SQLALCHEMY_TRACK_MODIFICATIONS"] = False if test_config is None: @@ -30,5 +33,10 @@ def create_app(test_config=None): migrate.init_app(app, db) # Register Blueprints here + from app.routes.routes import tasks_bp + app.register_blueprint(tasks_bp) + from app.routes.goal_routes import goals_bp + app.register_blueprint(goals_bp) return app + diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..ed9447f97 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -2,4 +2,21 @@ class Goal(db.Model): - goal_id = db.Column(db.Integer, primary_key=True) + goal_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + tasks = db.relationship("Task", back_populates="goal", lazy = True) + + + + def to_json(self): + return { + "id": self.goal_id, + "title": self.title + } + + @classmethod + def create_goal(cls, req_body): + new_goal = cls( + title = req_body["title"], + ) + return new_goal \ No newline at end of file diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..b434e7a39 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,58 @@ from app import db - +from datetime import datetime class Task(db.Model): - task_id = db.Column(db.Integer, primary_key=True) + id = db.Column(db.Integer, primary_key=True, ) + title = db.Column(db.String) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime, default = None) + # (- Nullable=True is default) + goal_id = db.Column(db.Integer, db.ForeignKey("goal.goal_id")) + goal = db.relationship("Goal", back_populates="tasks") + + + + def to_json(self): + + to_json_dict = { + "id": self.id, + "title": self.title, + "description": self.description, + "is_complete": True if self.completed_at else False + } + if self.goal_id: + to_json_dict["goal_id"] =self.goal_id + + return to_json_dict + + @classmethod + def create(cls, req_body): + if not "completed_at" in req_body: + completed_at_status = None + else: + completed_at_status = req_body["completed_at"] + + new_task = cls( + title = req_body["title"], + description = req_body["description"], + completed_at = completed_at_status + + ) + return new_task + + + def update(self, req_body): + + if not "completed_at" in req_body: + completed_at_status = None + else: + completed_at_status = req_body["completed_at"] + + + self.title = req_body["title"], + self.description = req_body["description"], + self.completed_at = completed_at_status + + + + diff --git a/app/routes.py b/app/routes.py deleted file mode 100644 index 3aae38d49..000000000 --- a/app/routes.py +++ /dev/null @@ -1 +0,0 @@ -from flask import Blueprint \ No newline at end of file diff --git a/app/routes/__init__.py b/app/routes/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/app/routes/goal_routes.py b/app/routes/goal_routes.py new file mode 100644 index 000000000..25155e36a --- /dev/null +++ b/app/routes/goal_routes.py @@ -0,0 +1,136 @@ +from pydoc import describe +from urllib import response +from flask import Blueprint, jsonify, request, make_response,abort +from app import db +from app.models.goal import Goal +from app.models.task import Task +from .helper import goal_validate_client_requests, validate_goal, validate_task + +goals_bp = Blueprint("goals", __name__,url_prefix="/goals" ) + +#GET all +@goals_bp.route("", methods = ["GET"]) +def get_all_goals(): + goals = Goal.query.all() + + goals_response = [] + for goal in goals: + goals_response.append(goal.to_json()) + + return jsonify(goals_response),200 + + +#GET one +@goals_bp.route("/", methods = ["GET"]) +def get_one_goal(goal_id): + goal = validate_goal(goal_id) + + return {"goal": goal.to_json()},200 + + +#CREATE one +@goals_bp.route("", methods = ["POST"]) +def create_one_goal(): + + request_body = request.get_json() + if "title" in request_body: + # new_goal = goal_validate_client_requests(request_body) + + #?????? why below does not work + # new_goal = Goal(title = request_body["title"]) + new_goal = Goal.create_goal(request_body) + db.session.add(new_goal) + db.session.commit() + + return {"goal": new_goal.to_json()}, 201 + else: + return {"details": "Invalid data"}, 400 + + + + + +#UPDATE one goal +@goals_bp.route("/", methods = ["PUT"]) +def update_one_goal(goal_id): + goal = validate_goal(goal_id) + + request_body = request.get_json() + goal.title = request_body["title"] + + db.session.commit() + + return make_response(jsonify({"goal": goal.to_json()}), 200) + + +#DELETE +@goals_bp.route("/", methods = ["DELETE"]) +def delete_goal(goal_id): + goal = validate_goal(goal_id) + + db.session.delete(goal) + db.session.commit() + + return {"details": f'Goal {goal.goal_id} "{goal.title}" successfully deleted'}, 200 + + + +# Sending a List of Task IDs to a Goal +@goals_bp.route("//tasks", methods = ["POST"]) +def create_tasks(goal_id): +#1 get goal for adding tasks: + goal = validate_goal(goal_id) + +#2 get tasks that need to add to goal + # 2.a get task ids from client + request_body = request.get_json() + # 2.b get tasks by ids from DB and connect with FK + for id in request_body["task_ids"]: + task = validate_task(id) + task.goal_id = goal_id + # or - add a list of tasks to goal + # goal.tasks.append(task) + # or - assign goal to task.goal + # task.goal = goal + + db.session.commit() + +#3 create respons body and return it + tasks_id_list =[] + for task in goal.tasks: + tasks_id_list.append(task.id) + response_body = { + "id": goal.goal_id, + "task_ids": tasks_id_list + } + return make_response(jsonify(response_body), 200) + + +#GET task from specific goal +@goals_bp.route("//tasks", methods = ["GET"]) +def get_task_from_specific_goal(goal_id): + #get target goal + goal = validate_goal(goal_id) + + + tasks_list = [] + for task in goal.tasks: + tasks_list.append( task.to_json()) + + response_boday = { + "id": goal.goal_id, + "title": goal.title, + "tasks": tasks_list + } + + + return response_boday, 200 + +#Get a specific Task under given Goal +@goals_bp.route("/tasks/", methods = ["GET"]) +def get_task_under_specific_goal(id): + task = validate_task(id) + goal_id = task.goal_id + + response_body = task.to_json() + return response_body, 200 diff --git a/app/routes/helper.py b/app/routes/helper.py new file mode 100644 index 000000000..640aa50e5 --- /dev/null +++ b/app/routes/helper.py @@ -0,0 +1,48 @@ +from app.models.task import Task +from app.models.goal import Goal +from flask import abort, make_response,request + + +def validate_task(id): + try: + id = int(id) + except: + abort(make_response({"message": f"Task{id} is invalid"}, 400)) + + task = Task.query.get(id) + if not task: + abort(make_response({"message": f"Task{id} not found"}, 404)) + + return task + + +def validate_client_requests(request_body): + try: + new_task = Task.create(request_body) + except KeyError: + abort(make_response({"details": "Invalid data"},400)) + + return new_task + + +def validate_goal(id): + try: + id = int(id) + except: + abort(make_response({"message": f"Goal{id} is invalid"}, 400)) + + goal = Goal.query.get(id) + if not goal: + abort(make_response({"message": f"Goal{id} not found"}, 404)) + + return goal + +def goal_validate_client_requests(request_body): + try: + new_goal = Goal.create(request_body) + except KeyError: + abort(make_response({"details": "Invalid data"},400)) + + return new_goal + + diff --git a/app/routes/routes.py b/app/routes/routes.py new file mode 100644 index 000000000..226fad409 --- /dev/null +++ b/app/routes/routes.py @@ -0,0 +1,120 @@ +from flask import Blueprint, jsonify, request, make_response +from app import db +from app.models.task import Task +from .helper import validate_client_requests, validate_task +from datetime import datetime +import requests, os # for Slackbot proj + +tasks_bp = Blueprint("tasks", __name__, url_prefix="/tasks") + +#Get all +@tasks_bp.route("", methods=["GET"]) +def get_all_tasks(): + title_sorted_query = request.args.get("sort") + if title_sorted_query == "asc": + tasks = Task.query.order_by(Task.title.asc()).all() + elif title_sorted_query == "desc": + tasks = Task.query.order_by(Task.title.desc()).all() + else: + tasks = Task.query.all() + tasks_response = [] + for task in tasks: + tasks_response.append(task.to_json()) + + return jsonify(tasks_response),200 + + +#Get one +@tasks_bp.route("/", methods=["GET"]) +def get_one_task(id): + task = validate_task(id) + + return {"task": task.to_json()}, 200 + + +#Create one +@tasks_bp.route("", methods=["POST"]) +def create_one_task(): + request_body = request.get_json() + new_task = validate_client_requests(request_body) + db.session.add(new_task) + db.session.commit() + return {"task": new_task.to_json()}, 201 + + # or without helper function: + #request_body = request.get_json() + #if "title" in request_body and "description" in request_body: + # new_task = Task.create(request_body) + # db.session.add(new_task) + # db.session.commit() + # else: + # return {"details": "Invalid data"}, 400 + + +#Update one - PUT +@tasks_bp.route("/", methods=["PUT"]) +def update_one_task(id): + task = validate_task(id) + request_body = request.get_json() +# response = client.put("/tasks/1", json={ +# "title": "Updated Task Title", +# "description": "Updated Test Description", +# "completed_at": datetime.utcnow() or None +# }) + task.update(request_body) + # >>> def update(self, req_body): + # >>>>>> self.title = req_body["title"], + # >>>>>> self.description = req_body["description"] + db.session.commit() + return {"task": task.to_json()}, 200 + + +#Delete one +@tasks_bp.route("/", methods=["DELETE"]) +def delete_one_task(id): + task = validate_task(id) + db.session.delete(task) + db.session.commit() + return {"details": f'Task {id} "Go on my daily walk 🏞" successfully deleted'} + + +#Patch: mark complete +@tasks_bp.route("//mark_complete", methods=["PATCH"]) +def mark_complete_on_incomplete_task(id): + task = validate_task(id) + # request_body = request.get_json() + # - Why dont need request_body, bc I got the task needs to be \ + # update from line 79. task.completed_at = None bc it was \ + # incompleted and request to change to completed (assign time value) + task.completed_at = datetime.utcnow() + # db.session.commit() + + #add slackbot + # message = f"Someone just completed the task {task.title}" + + path = "https://slack.com/api/chat.postMessage" + + headers = {"Authorization":os.environ.get("SLACK_API_KEY")} + + query_params = { + # "token": SLACK_TOKEN, + "channel": "test-channel", + "text": f"Someone just completed the task {task.title}" + # "format": "json" + } + + requests.post(path, params=query_params, headers=headers) + db.session.commit() + # return make_response({"task": task.to_json()}), 200 + return jsonify({"task": task.to_json()}), 200 + +#Patch:mark imcomplete +@tasks_bp.route("//mark_incomplete", methods=["PATCH"]) +def mark_incomplete_on_complete_task(id): + task = validate_task(id) + task.completed_at = None + db.session.commit() + return {"task": task.to_json()}, 200 + + + diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/db7977da69af_added_one_to_many_relation_between_goal_.py b/migrations/versions/db7977da69af_added_one_to_many_relation_between_goal_.py new file mode 100644 index 000000000..73387dc95 --- /dev/null +++ b/migrations/versions/db7977da69af_added_one_to_many_relation_between_goal_.py @@ -0,0 +1,42 @@ +"""added one to many relation between goal(one) and task(many) tables + +Revision ID: db7977da69af +Revises: +Create Date: 2022-05-12 12:08:37.962632 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'db7977da69af' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.PrimaryKeyConstraint('goal_id') + ) + op.create_table('task', + sa.Column('id', sa.Integer(), nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.Column('goal_id', sa.Integer(), nullable=True), + sa.ForeignKeyConstraint(['goal_id'], ['goal.goal_id'], ), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index 30ff414fe..143ec15af 100644 --- a/requirements.txt +++ b/requirements.txt @@ -5,6 +5,7 @@ blinker==1.4 certifi==2020.12.5 chardet==4.0.0 click==7.1.2 +coverage==6.3.2 Flask==1.1.2 Flask-Migrate==2.6.0 Flask-SQLAlchemy==2.4.4 diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..854a1d04d 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -60,13 +60,13 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body")??????? # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {'message': 'Task1 not found'} - -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +93,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +119,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -131,13 +131,13 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {'message': 'Task1 not found'} - -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +152,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -161,15 +161,15 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** - + assert response_body == {'message': 'Task1 not found'} assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +186,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..c9a76e6b1 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 959176ceb..c6429aea7 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -24,7 +24,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): mock_get.return_value.status_code = 200 # Act - response = client.patch("/tasks/1/mark_complete") + response = client.patch("/tasks/1/mark_complete") response_body = response.get_json() # Assert @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -81,7 +81,7 @@ def test_mark_complete_on_completed_task(client, completed_task): mock_get.return_value.status_code = 200 # Act - response = client.patch("/tasks/1/mark_complete") + response = client.patch("/tasks/1/mark_complete") response_body = response.get_json() # Assert @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -128,13 +128,13 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {'message': 'Task1 not found'} - -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -143,15 +143,15 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** - + assert response_body == {'message': 'Task1 not found'} # Let's add this test for creating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_with_valid_completed_at(client): # Act response = client.post("/tasks", json={ @@ -181,7 +181,7 @@ def test_create_task_with_valid_completed_at(client): # Let's add this test for updating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_with_completed_at_date(client, completed_task): # Act response = client.put("/tasks/1", json={ diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..970613f57 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,7 @@ import pytest +from app.models.goal import Goal - -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +12,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +29,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +46,24 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") + # raise Exception("Complete test") # Assert # ---- Complete Test ---- # assertion 1 goes here + assert response_body == {"message": "Goal1 not found"} # assertion 2 goes here + assert response.status_code == 404 # ---- Complete Test ---- -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +82,44 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") + # raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated goal title" + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated goal title" + } + } + goal = Goal.query.get(1) + assert goal.title == "Updated goal title" -@pytest.mark.skip(reason="test to be completed by student") + +#@pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act - # ---- Complete Act Here ---- - + response = client.put("/goals/1", json={ + "title": "Updated Goal Title", + }) + response_body = response.get_json() + # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert response_body == {'message': 'Goal1 not found'} -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -124,27 +136,26 @@ def test_delete_goal(client, one_goal): response = client.get("/goals/1") assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** - # ***************************************************************** + assert Goal.query.get(1) == None -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response_body == {'message': 'Goal1 not found'} + assert Goal.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..649c8cec0 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +42,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -51,13 +51,11 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + # raise Exception("Complete test with assertion about response body") + assert response_body == {"message": "Goal1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +72,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +97,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()