Skip to content

[C++] Update proto files #5286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 3 tasks
charlesbvll opened this issue Apr 23, 2025 · 3 comments · May be fixed by #5287
Open
1 of 3 tasks

[C++] Update proto files #5286

charlesbvll opened this issue Apr 23, 2025 · 3 comments · May be fixed by #5287
Assignees
@charlesbvll

Comments

@charlesbvll
Copy link
Member

charlesbvll commented Apr 23, 2025 •
edited
Loading

Describe the type of feature and its functionality.

The proto files listed in the CMakeLists.txt file for building the C++ SDK include recordset.proto, task.proto which no longer exist. It is also missing message.proto which is a dependency for other proto files.

Describe step by step what files and adjustments are you planning to include.

  • Update CMakeLists.txtto list the correct proto files
  • Update references to those proto files in src/
  • Update serde functions to use the Message API instead of TaskIns/TaskRes (this is quite big)

Is there something else you want to add?

No response
@charlesbvll charlesbvll self-assigned this Apr 23, 2025
This was referenced Apr 23, 2025
Closed
Draft
@charlesbvll charlesbvll linked a pull request Apr 23, 2025 that will close this issue
fix(framework) Remove outdated proto files for C++ SDK #5287
Draft
5 tasks
@charlesbvll charlesbvll changed the title [C++] RecordSet needs to be updated to RecordDict [C++] Update proto files Apr 23, 2025
@charlesbvll
Copy link
Member Author

@uncleDecart I opened #5287, feel free to push to it (or to open PRs on the branch), I think the todo for switching to the Message API is quite a big topic, we could try to have a sync if you are interested in working on it

@uncleDecart
Copy link

@charlesbvll thank you very much! Would be great if you bring me up to speed. Shall I contact you on Slack to schedule the meeting?

@charlesbvll
Copy link
Member Author

@uncleDecart Yes perfect!

@WilliamLindskog WilliamLindskog modified the milestones: Future Release, 2025 Releases May 1, 2025
@WilliamLindskog WilliamLindskog mentioned this issue May 12, 2025
Open
@WilliamLindskog WilliamLindskog removed this from the 2025 Releases milestone May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlesbvll charlesbvll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(framework) Remove outdated proto files for C++ SDK adap/flower
4 participants
@danieljanes @charlesbvll @uncleDecart @WilliamLindskog