Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button do not work; logo/icon disappears in chrome #49

Open
RH-BD opened this issue Jun 5, 2021 · 3 comments
Open

Save button do not work; logo/icon disappears in chrome #49

RH-BD opened this issue Jun 5, 2021 · 3 comments

Comments

@RH-BD
Copy link

RH-BD commented Jun 5, 2021

In the options page, save button do not work; therefore, can't change Options. could be more lightweight. should have some exception/whitelist.
Update 1: Sometimes icon/logo disappears from the Search result.

@RH-BD RH-BD changed the title Save button do not work; doc do not open in chrome Save button do not work; logo/icon disappears in chrome Jun 5, 2021
@adeekshith
Copy link
Owner

Can reproduce the save button issue. Will see whats going on. Thanks for reporting!

Sometimes icon/logo disappears from the Search result

It checks if the URL headers actually match the document and if not, it removes the icon. For example if the URL shows file.doc but if it is actually a HTML file, then it detects and drops the icon for it.

@RH-BD
Copy link
Author

RH-BD commented Jun 8, 2021

image
Please see the above picture where only one .doc file had icon/logo but two others in the immediate below had none. Also, I was unable check the option: "Open in a tab" and save it (in fact, I was unable to save any options, even if I check other file types; save option do not work for me.).
I request you to get rid of this icon/logo options altogether. In the chrome store I found another new extension called: "In-Browser File Viewer" which just simply let users to click the .doc file link to open. Which indicating that, such permission from google/chrome is also possible. In your extension, user have to pin-point the pointer to click in the icon/logo which is time-consuming and annoying.

@kareemagha
Copy link

I have the same issue with saving options. I assume there is something wrong with the chrome storage get or set functions. I tried to edit the code with this: https://developer.chrome.com/docs/extensions/mv3/options/ , but I had no luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants