Skip to content

Commit a9e49d3

Browse files
committedMar 13, 2025·
unadf tests: rename expected result files to match test names.
1 parent 3089690 commit a9e49d3

24 files changed

+37
-33
lines changed
 

‎examples/Makefile.am

+22-22
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,18 @@ dist_check_DATA = \
2323
tests/results/adf-show-metadata-test_3 \
2424
tests/results/adf-show-metadata-test_4 \
2525
tests/results/adf-show-metadata-test_5 \
26-
tests/results/unadf_1 \
26+
tests/results/unadf_no_args \
2727
tests/results/unadf_help \
28-
tests/results/unadf_2 \
29-
tests/results/unadf_3 \
30-
tests/results/unadf_4 \
31-
tests/results/unadf_5 \
32-
tests/results/unadf_6 \
33-
tests/results/unadf_7 \
34-
tests/results/unadf_8 \
35-
tests/results/unadf_9 \
36-
tests/results/unadf_10 \
37-
tests/results/unadf_11 \
28+
tests/results/unadf_invalid_args_1 \
29+
tests/results/unadf_invalid_args_2 \
30+
tests/results/unadf_list_root_directory_option \
31+
tests/results/unadf_list_entire_disk_option \
32+
tests/results/unadf_show_logical_block_pointer_option \
33+
tests/results/unadf_extract_to_dir \
34+
tests/results/unadf_extract_to_dir_with_specific_files \
35+
tests/results/unadf_extract_to_pipe_option \
36+
tests/results/unadf_mangle_win32_filenames_option \
37+
tests/results/unadf_confirm_the_mangling \
3838
tests/results_msys/adf-floppy-test_1 \
3939
tests/results_msys/adf-floppy-test_2 \
4040
tests/results_msys/adf-floppy-test_3 \
@@ -44,18 +44,18 @@ dist_check_DATA = \
4444
tests/results_msys/adf-show-metadata-test_3 \
4545
tests/results_msys/adf-show-metadata-test_4 \
4646
tests/results_msys/adf-show-metadata-test_5 \
47-
tests/results_msys/unadf_1 \
47+
tests/results_msys/unadf_no_args \
4848
tests/results_msys/unadf_help \
49-
tests/results_msys/unadf_2 \
50-
tests/results_msys/unadf_3 \
51-
tests/results_msys/unadf_4 \
52-
tests/results_msys/unadf_5 \
53-
tests/results_msys/unadf_6 \
54-
tests/results_msys/unadf_7 \
55-
tests/results_msys/unadf_8 \
56-
tests/results_msys/unadf_9 \
57-
tests/results_msys/unadf_10 \
58-
tests/results_msys/unadf_11
49+
tests/results_msys/unadf_invalid_args_1 \
50+
tests/results_msys/unadf_invalid_args_2 \
51+
tests/results_msys/unadf_list_root_directory_option \
52+
tests/results_msys/unadf_list_entire_disk_option \
53+
tests/results_msys/unadf_show_logical_block_pointer_option \
54+
tests/results_msys/unadf_extract_to_dir \
55+
tests/results_msys/unadf_extract_to_dir_with_specific_files \
56+
tests/results_msys/unadf_extract_to_pipe_option \
57+
tests/results_msys/unadf_mangle_win32_filenames_option \
58+
tests/results_msys/unadf_confirm_the_mangling
5959

6060
check_SCRIPTS = $(dist_check_SCRIPTS)
6161
check_DATA = $(dist_check_DATA)
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

‎examples/tests/unadf-test.sh

+15-11
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ UNADF=`get_test_cmd unadf`
77
# check no args
88
check_no_args() {
99
$( $UNADF >$actual 2>&1 || exit 0; )
10-
compare_with "check no args" unadf_1
10+
compare_with "check no args" unadf_no_args
1111
}
1212

1313
check_help() {
@@ -18,28 +18,30 @@ check_help() {
1818
# check invalid args
1919
check_invalid_args() {
2020
$( $UNADF -v >$actual 2>&1 || exit 0; )
21-
compare_with "check invalid arg for -v" unadf_2
21+
compare_with "check invalid arg for -v" unadf_invalid_args_1
2222

2323
$( $UNADF -d >$actual 2>&1 || exit 0; )
24-
compare_with "check invalid arg for -d" unadf_3
24+
compare_with "check invalid arg for -d" unadf_invalid_args_2
2525
}
2626

2727
# -l (list root directory) option
2828
check_list_root_directory_option() {
2929
$UNADF -l "$basedir/arccsh.adf" >$actual 2>/dev/null
30-
compare_with "-l (list root directory) option" unadf_4
30+
compare_with "-l (list root directory) option" \
31+
unadf_list_root_directory_option
3132
}
3233

3334
# -r (list entire disk) option
3435
check_list_entire_disk_option() {
3536
$UNADF -r "$basedir/arccsh.adf" >$actual 2>/dev/null
36-
compare_with "-r (list entire disk) option" unadf_5
37+
compare_with "-r (list entire disk) option" unadf_list_entire_disk_option
3738
}
3839

3940
# -s (show logical block pointer) option
4041
check_show_logical_block_pointer_option() {
4142
$UNADF -ls "$basedir/arccsh.adf" >$actual 2>/dev/null
42-
compare_with "-s (show logical block pointer) option" unadf_6
43+
compare_with "-s (show logical block pointer) option" \
44+
unadf_show_logical_block_pointer_option
4345
}
4446
# TODO -c (use dircache data) option
4547
# TODO -m (display file comments) option
@@ -48,7 +50,7 @@ check_show_logical_block_pointer_option() {
4850
# -d (extract to dir)
4951
check_extract_to_dir() {
5052
$UNADF -d $tmpdir/x "$basedir/arccsh.adf" >$actual 2>/dev/null
51-
compare_with "-d (extract to dir)" unadf_7
53+
compare_with "-d (extract to dir)" unadf_extract_to_dir
5254

5355
# check permissions were set on extracted files
5456
# (these tests are failing on MSYS2:
@@ -68,26 +70,28 @@ check_extract_to_dir_with_specific_files() {
6870
$UNADF -d $tmpdir/x "$basedir/arccsh.adf" csh s/startup-sequence \
6971
devs/system-configuration >$actual 2>/dev/null
7072
compare_with "-d (extract to dir) with specific files, not all their original case" \
71-
unadf_8
73+
unadf_extract_to_dir_with_specific_files
7274
}
7375
# TODO check permissions were set (bug: currently they aren't)
7476

7577
# -p (extract to pipe) option
7678
check_extract_to_pipe_option() {
7779
$UNADF -p "$basedir/arccsh.adf" s/startup-sequence >$actual 2>/dev/null
78-
compare_with " -p (extract to pipe) option" unadf_9
80+
compare_with " -p (extract to pipe) option" unadf_extract_to_pipe_option
7981
}
8082

8183
# -w (mangle win32 filenames) option
8284
check_mangle_win32_filenames_option() {
8385
$UNADF -d $tmpdir/x -w "$basedir/win32-names.adf" >$actual 2>/dev/null
84-
compare_with "-w (mangle win32 filenames) option" unadf_10
86+
compare_with "-w (mangle win32 filenames) option" \
87+
unadf_mangle_win32_filenames_option
8588
}
8689

8790
# confirm the mangling (-w) only occurs on extraction
8891
check_confirm_the_mangling() {
8992
$UNADF -r -w "$basedir/win32-names.adf" >$actual 2>/dev/null
90-
compare_with "confirm the mangling (-w) only occurs on extraction" unadf_11
93+
compare_with "confirm the mangling (-w) only occurs on extraction" \
94+
unadf_confirm_the_mangling
9195
}
9296

9397

0 commit comments

Comments
 (0)
Please sign in to comment.