Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve adf_salv (salvage) #53

Open
t-w opened this issue Jun 9, 2023 · 3 comments
Open

Improve adf_salv (salvage) #53

t-w opened this issue Jun 9, 2023 · 3 comments

Comments

@t-w
Copy link
Collaborator

t-w commented Jun 9, 2023

The adf_salv module, with the very useful undel functions, needs improvements in terms of:

  • memory management (ie. memory leaks)
  • error checking (eg. undeleting things not checking if the blocks are read correctly)

(Since in some cases possibly the error check should be avoided (even if a checksum is not correct, data could be recovered), the issue is created to take notes/comments on this).
t-w added a commit to t-w/ADFlib that referenced this issue Jun 9, 2023
@t-w
adf_salv / adfGetDelEnt: fix a memory leak, adflib#53
893c92f
t-w added a commit to t-w/ADFlib that referenced this issue Jun 9, 2023
@t-w
adfGetDelEnt: add error checking while reading blocks, adflib#53
a5f5e15
t-w added a commit to t-w/ADFlib that referenced this issue Jun 9, 2023
@t-w
adfCheckParent: add error checking while reading blocks, adflib#53
91a9c19
t-w added a commit to t-w/ADFlib that referenced this issue Jun 9, 2023
@t-w
adfUndelDir: add error checking, adflib#53
7d64b22
t-w added a commit to t-w/ADFlib that referenced this issue Jun 9, 2023
@t-w
adfUndelFile: add error checking, adflib#53
14cc372
t-w added a commit to t-w/ADFlib that referenced this issue Jun 9, 2023
@t-w
adfUndelEntry: add error checking, adflib#53
bf0fee4
t-w added a commit to t-w/ADFlib that referenced this issue Jun 9, 2023
@t-w
adfCheckFile: add error checking, adflib#53
3be1ceb
t-w added a commit to t-w/ADFlib that referenced this issue Jun 9, 2023
@t-w
adfCheckEntry: add error checking, adflib#53
c653d17
@lclevy
Copy link
Collaborator

lclevy commented Jun 9, 2023

Inspiration was disksalv https://www.nightvzn.net/portfolio/web/amiga_monitor/archives/1_5html/disksalv.htm

@t-w
Copy link
Collaborator Author

t-w commented Jun 9, 2023

Good to know!

@t-w
Copy link
Collaborator Author

t-w commented May 18, 2024

There is still (at least...) one thing left:

  • adfUndelFile(): add reverting adfCreateEntry in case adfAddInCache fails.
    While this should be relatively rare case, nevertheless, it should be fixed/improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lclevy @t-w