Skip to content

Commit 9f15ce3

Browse files
committed
Make things work on Windows
Problem: Theano relies on g++, which means we need to install MinGW on Windows. Unfortunately, MinGW is incompatible with MSVC 2015, which is used to build libpython3.5 (necessary for linking). See ContinuumIO/anaconda-issues#561 Solution: Downgrade to Python 3.4 Problem: Currently, `environment.yml` doesn't support platform-specific selectors. We're waiting on conda env to merge conda-archive/conda-env#213 Solution: Run `conda install libpython` as a seperate step on Windows only
1 parent 4eaa2cb commit 9f15ce3

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

appveyor.yml

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ build_script:
66
- conda update --yes --quiet conda
77
- conda env create --quiet --name accessibleml
88
- activate accessibleml
9+
- conda install --yes --quiet libpython
910
before_test:
1011
- conda env export
1112
test_script:

environment.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ dependencies:
66
- pandas=0.17
77
- pillow=3.1
88
- pytest # testing dependency
9-
- python=3.5
9+
- python=3.4
1010
- scikit-learn=0.17
1111
- scipy=0.17
1212
- statsmodels=0.6

test/test_notebook.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
import nbformat
55
import pytest
66

7-
notebooks = list(glob.glob("*.ipynb", recursive=True))
7+
notebooks = sorted(glob.glob("*.ipynb"))
88

99

1010
@pytest.mark.parametrize("notebook", notebooks)
1111
def test_notebook_execution(notebook):
1212
with open(notebook) as fin:
1313
nb = nbformat.read(fin, as_version=4)
1414

15-
ep = ExecutePreprocessor(timeout=1200, kernel_name="python3")
15+
ep = ExecutePreprocessor(timeout=2400, kernel_name="python3")
1616
ep.preprocess(nb, resources={})
1717

1818

0 commit comments

Comments
 (0)